add kGray_8_SkColorType

add kGray_8_SkColorType

BUG=skia:

[reed1, 2015-03-17 13:16:19]

reed@google.com changed reviewers:
+ robertphillips@google.com

[reed1, 2015-03-17 13:16:19]

will replace hacked gm with a real one

[reed1, 2015-03-17 13:16:27]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-17 13:16:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1014783003/1

[commit-bot: I haz the power, 2015-03-17 13:16:36]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-17 19:16 UTC

[reed1, 2015-03-17 13:16:46]

The CQ bit was unchecked by reed@google.com

[robertphillips, 2015-03-17 17:33:00]

lgtm + stuff

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkBitmap.cpp#n...
src/core/SkBitmap.cpp:852: switch (srcCT) {
Surely we can handle 565 and 4444 ?

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkBitmapProcSt...
File src/core/SkBitmapProcState_procs.h (right):

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkBitmapProcSt...
src/core/SkBitmapProcState_procs.h:213: do {                                    
                   \
I liked the tab(s) :(

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkConfig8888.cpp
File src/core/SkConfig8888.cpp (right):

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkConfig8888.c...
src/core/SkConfig8888.cpp:152: 
// Perceptual conversion factors from RGB to Grayscale ?

[robertphillips, 2015-03-17 17:33:15]

-- modulo the GM changes

[reed1, 2015-03-17 19:40:45]

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkBitmap.cpp#n...
src/core/SkBitmap.cpp:852: switch (srcCT) {
On 2015/03/17 17:33:00, robertphillips wrote:
> Surely we can handle 565 and 4444 ?

Left as an exercise for the reader... or a future cl.

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkBitmapProcSt...
File src/core/SkBitmapProcState_procs.h (right):

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkBitmapProcSt...
src/core/SkBitmapProcState_procs.h:213: do {                                    
                   \
On 2015/03/17 17:33:00, robertphillips wrote:
> I liked the tab(s) :(

Done.

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkConfig8888.cpp
File src/core/SkConfig8888.cpp (right):

https://codereview.chromium.org/1014783003/diff/20001/src/core/SkConfig8888.c...
src/core/SkConfig8888.cpp:152: 
On 2015/03/17 17:33:00, robertphillips wrote:
> // Perceptual conversion factors from RGB to Grayscale ?

using SkComputeLuminance()

[reed1, 2015-03-17 20:42:17]

reed@google.com changed reviewers:
+ scroggo@google.com

[reed1, 2015-03-17 20:42:18]

leon, does this look reasonable to add to jpeg (at least) -- allowing libjpeg to
report Gray8 has its "native" config?

[scroggo, 2015-03-17 20:54:32]

On 2015/03/17 20:42:18, reed1 wrote:
> leon, does this look reasonable to add to jpeg (at least) -- allowing libjpeg
to
> report Gray8 has its "native" config?

Yes. As discussed in person, we'll want to switch Android from using Alpha8 to
mean Gray8.

Also, FWIW, JPEG supports a gray with an alpha (16bit, IIRC). Not sure if we
want to support that.

https://codereview.chromium.org/1014783003/diff/40001/src/pdf/SkPDFImage.cpp
File src/pdf/SkPDFImage.cpp (right):

https://codereview.chromium.org/1014783003/diff/40001/src/pdf/SkPDFImage.cpp#...
src/pdf/SkPDFImage.cpp:130: static SkStream* extract_gray8_image(const SkBitmap&
bitmap, const SkIRect& srcRect) {
Run this by Hal?

[reed2, 2015-03-17 21:54:56]

reed@chromium.org changed reviewers:
+ reed@chromium.org

[reed2, 2015-03-17 21:54:56]

alpha+luminance might be useful too in the future.

https://codereview.chromium.org/1014783003/diff/40001/src/pdf/SkPDFImage.cpp
File src/pdf/SkPDFImage.cpp (right):

https://codereview.chromium.org/1014783003/diff/40001/src/pdf/SkPDFImage.cpp#...
src/pdf/SkPDFImage.cpp:130: static SkStream* extract_gray8_image(const SkBitmap&
bitmap, const SkIRect& srcRect) {
On 2015/03/17 20:54:32, scroggo wrote:
> Run this by Hal?

Hal gave me the pointer to this section.

[reed2, 2015-03-17 21:55:00]

The CQ bit was checked by reed@chromium.org

[reed2, 2015-03-17 21:55:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1014783003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-03-17 21:55:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1014783003/60001

[commit-bot: I haz the power, 2015-03-17 22:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-17 22:00:45]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)

[reed2, 2015-03-17 22:06:30]

need to update get_uncompressed_size() in SkPDFImage.cpp.