Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1035763003: Revert of Test Accelerators In Interactive UI Tests (Closed)

Created:
5 years, 9 months ago by James Cook
Modified:
5 years, 9 months ago
Reviewers:
afakhry, oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Test Accelerators In Interactive UI Tests (patchset #5 id:80001 of https://codereview.chromium.org/1026513005/) Reason for revert: AcceleratorInteractiveUITest.ChromeOsAccelerators and AcceleratorInteractiveUITest.TestNonRepeatableNeedingWindowActions are failing on the cros_trunk official builders. http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/31840 Original issue's description: > Test Accelerators In Interactive UI Tests > > In order to avoid future regressions. > > BUG=469235 > TEST=interactive_ui_tests --gtest_filter=AcceleratorInteractiveUITest.* > > Committed: https://crrev.com/b0c1e2d572b2bda87f11007c89ecdaac6301770a > Cr-Commit-Position: refs/heads/master@{#322076} TBR=oshima@chromium.org,afakhry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=469235 Committed: https://crrev.com/531e5de190fbba5fda62175101e14ace7038c7da Cr-Commit-Position: refs/heads/master@{#322184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -234 lines) Patch
D ash/accelerators/accelerator_interactive_uitest.cc View 1 chunk +0 lines, -233 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Created Revert of Test Accelerators In Interactive UI Tests
5 years, 9 months ago (2015-03-25 17:18:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035763003/1
5 years, 9 months ago (2015-03-25 17:18:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 17:19:28 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 17:20:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/531e5de190fbba5fda62175101e14ace7038c7da
Cr-Commit-Position: refs/heads/master@{#322184}

Powered by Google App Engine
This is Rietveld 408576698