commit | 108c0687254683b3beeaa32b6e0a86f2046a867e | [log] [tgz] |
---|---|---|
author | Alan Cutter <alancutter@chromium.org> | Tue Jul 03 05:03:29 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jul 03 05:03:29 2018 |
tree | 7ee2d0819b2837cbae2119f4db75db0baf564381 | |
parent | 0e41546585711ceaa448092981a8273088313d24 [diff] |
Add the zoom icon to hosted app title bars This CL moves the ZoomView icon from LocationBarView to PageActionIconContainerView for reusability in the HostedAppButtonContainer. The user visible effect of this is the zoom icon can be seen in hosted app window title bars, see screenshots below. As part of this generalisation: - The PageActionIconView::Delegate class now reads an SkColor instead of an OmniboxTint for consistency with other title bar icons, see screenshots below. - The size of the zoom icon (and other page action icons that get migrated in the future) is reduced in touch optimised mode for the HostedAppButtonContainer to avoid stretching the title bar region vertically when shown. Native icon colours: https://bugs.chromium.org/p/chromium/issues/attachment?aid=339750&signed_aid=0n6nlPPzzcaH-Xc58twlyA==&inline=1 Light theme icon colours: https://bugs.chromium.org/p/chromium/issues/attachment?aid=339751&signed_aid=Rg4OpeJyhj-_-5vGILuzYw==&inline=1 Dark theme icon colours: https://bugs.chromium.org/p/chromium/issues/attachment?aid=339752&signed_aid=EbybLy_ZlxoIfr2cKOjqzw==&inline=1 Bug: 788051 Change-Id: I8b761f1efbce8cdb62c6501327fdfcfe7ba7d912 Reviewed-on: https://chromium-review.googlesource.com/1051141 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#572114}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .