Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1132753002: [CSS Grid Layout] Fix grid shorthands CSSOM serialization (Closed)

Created:
5 years, 7 months ago by Manuel Rego
Modified:
5 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, jfernandez, Manuel Rego, rwlbuis, svillar
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Fix grid shorthands CSSOM serialization Grid shorthands use slash instead of whitespace as separator. Modified StylePropertySerializer::getShorthandValue() to allow specify a separator different than whitespace. TEST=fast/css-grid-layout/grid-shorthands-style-format.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195148

Patch Set 1 #

Patch Set 2 : Update test expectations for webexposed/nonstable-css-properties.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -9 lines) Patch
A LayoutTests/fast/css-grid-layout/grid-shorthands-style-format.html View 1 chunk +66 lines, -0 lines 0 comments Download
A LayoutTests/fast/css-grid-layout/grid-shorthands-style-format-expected.txt View 1 chunk +36 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/StylePropertySerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Manuel Rego
5 years, 7 months ago (2015-05-08 07:36:58 UTC) #2
dsinclair
lgtm
5 years, 7 months ago (2015-05-08 13:18:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132753002/1
5 years, 7 months ago (2015-05-08 13:18:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/62180)
5 years, 7 months ago (2015-05-08 16:14:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132753002/20001
5 years, 7 months ago (2015-05-08 20:15:46 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-09 10:30:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195148

Powered by Google App Engine
This is Rietveld 408576698