Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1151023004: Add use counters to determine the fate of DOMError (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
jsbell
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, nhiroki, vivekg, dglazkov+blink, tzik, Inactive, cmumford, dgrogan, jsbell+idb_chromium.org, kinuko+fileapi, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Add use counters to determine the fate of DOMError This covers all ways to get or use a DOMError except the StorageErrorCallback used in modules/quota. If those callbacks actually look DOMError, that would be seen on the name/message counters. BUG=460725 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M Source/core/dom/DOMError.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/fileapi/FileReader.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBTransaction.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151023004/1
5 years, 6 months ago (2015-06-05 17:46:12 UTC) #3
philipj_slow
PTAL
5 years, 6 months ago (2015-06-05 17:46:12 UTC) #4
jsbell
lgtm... (and I'm sure philipj has thought about what I'm about to write but...) I ...
5 years, 6 months ago (2015-06-05 17:54:33 UTC) #5
philipj_slow
On 2015/06/05 17:54:33, jsbell wrote: > lgtm... > > (and I'm sure philipj has thought ...
5 years, 6 months ago (2015-06-05 18:13:43 UTC) #6
jsbell
> Also, measuring these attributes will say something about the > usage in the callback ...
5 years, 6 months ago (2015-06-05 18:15:28 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-05 18:45:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151023004/1
5 years, 6 months ago (2015-06-05 18:48:30 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 18:52:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196597

Powered by Google App Engine
This is Rietveld 408576698