Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1165563005: Add ftmm.c to FreeType build. (Closed)

Created:
5 years, 6 months ago by bungeman-chromium
Modified:
5 years, 6 months ago
Reviewers:
Xianzhu
Base URL:
https://chromium.googlesource.com/chromium/src/third_party/freetype.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add ftmm.c to FreeType build. The FreeType configuration is already building with TT_CONFIG_OPTION_GX_VAR_SUPPORT, but the functions cannot be accessed without base/ftmm.c. The ftmm.c file is small and simply exposes the means to call the service which already exists on the ft_face.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Android.mk View 1 chunk +1 line, -0 lines 0 comments Download
M freetype.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bungeman-chromium
Note that this is currently landing in aosp at https://android-review.googlesource.com/#/c/152373/ .
5 years, 6 months ago (2015-05-29 22:28:20 UTC) #3
Xianzhu
lgtm
5 years, 6 months ago (2015-05-29 22:32:25 UTC) #4
bungeman-chromium
On 2015/05/29 22:32:25, Xianzhu wrote: > lgtm Apparently I can't land this. I'm getting "error: ...
5 years, 6 months ago (2015-06-01 14:14:55 UTC) #8
Xianzhu
On 2015/06/01 14:14:55, bungeman2 wrote: > On 2015/05/29 22:32:25, Xianzhu wrote: > > lgtm > ...
5 years, 6 months ago (2015-06-01 15:58:24 UTC) #9
bungeman-chromium
5 years, 6 months ago (2015-06-01 16:03:37 UTC) #10
On 2015/06/01 15:58:24, Xianzhu wrote:
> On 2015/06/01 14:14:55, bungeman2 wrote:
> > On 2015/05/29 22:32:25, Xianzhu wrote:
> > > lgtm
> > 
> > Apparently I can't land this. I'm getting "error: failed to push some refs
to
> > 'https://chromium.googlesource.com/chromium/src/third_party/freetype.git'".
> I'm
> > fairly sure I'm set up to land things (I've done it for DEPS rolls before)
and
> > the gerrit permissions don't appear too strict. Is there something special
> that
> > needs to be done to land here?
> 
> I cloned this CL as https://codereview.chromium.org/1156023005 and landed it
> successfully (using 'git cl land'). What command did you use?
> 
> Anyway, you can continue to roll deps.

Thank you, I was trying to 'git cl land' but it wasn't working, with 'git push
origin master:master' telling me that gerrit had decided I don't have some
permission. The permissions at chromium-review.googlesource.com don't seem to
make sense, and the ones at gerrit.chromium.org seem to require being in the
android_tools group (or something like that) but I'm not sure those are the
permissions used anymore? In any event I opened an issue asking infra what the
current state of the world is and what I would need to land here.

Powered by Google App Engine
This is Rietveld 408576698