[SP] Enable Slimming Paint by default in Chromium and Blink.

[SP] Enable Slimming Paint by default in Chromium and Blink.

Add a --disable-slimming-paint flag and make slimming paint
on by default with no flags specified. --enable-slimming-paint
takes precedence over --disable-slimming-paint if both are
specified.

Existence of both flags is required to deal gracefully with
Blink-side LayoutTests and a gradual migration. For more, see:

https://groups.google.com/a/chromium.org/d/msg/paint-dev/gtRRHn1yotk/f_8iJgHP130J
https://groups.google.com/a/chromium.org/d/msg/paint-dev/uVGvSuVilaw/uA3iVa7JpuUJ

BUG=497950
Committed: https://crrev.com/af7391ec1e53b6725c1effb51bd83dae54a47568
Cr-Commit-Position: refs/heads/master@{#334188}

[wkorman, 2015-06-09 18:43:06]

wkorman@chromium.org changed reviewers:
+ chrishtr@chromium.org, enne@chromium.org

[wkorman, 2015-06-09 18:43:16]

The CQ bit was checked by wkorman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 18:43:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/20001

[wkorman, 2015-06-09 18:51:22]

The CQ bit was checked by wkorman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 18:52:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/40001

[commit-bot: I haz the power, 2015-06-09 19:49:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 19:49:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[enne (OOO), 2015-06-09 20:00:22]

non-owner lgtm, so long as test expectations have been updated such that
*_blink_rel try bots pass.

[wkorman, 2015-06-09 20:11:25]

The CQ bit was checked by wkorman@chromium.org to run a CQ dry run

[wkorman, 2015-06-09 20:11:25]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/1169193003/#ps60001
(title: "Add disable-slimming-paint to histograms.xml.")

[commit-bot: I haz the power, 2015-06-09 20:13:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/60001

[Xianzhu, 2015-06-09 20:46:00]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2015-06-09 20:49:20]

Added mac_blink_rel, linux_blink_rel, win_blink_rel try bots to examine blink
failures.

wkorman@ what's your plan before and/or after landing this CL (which will break
blink bots)?

[wkorman, 2015-06-09 20:57:23]

On 2015/06/09 at 20:49:20, wangxianzhu wrote:
> Added mac_blink_rel, linux_blink_rel, win_blink_rel try bots to examine blink
failures.
> 
> wkorman@ what's your plan before and/or after landing this CL (which will
break blink bots)?

Thanks, I was going to add those after seeing output of straight CQ since it was
already underway.

There are basically three things in flight currently:

1. This change.
2. http://crrev.com/1166223002
3. Fixing LayoutTest expectations to go with #2, possibly separate change(s), or
part of #2

My rough plan was:

- submit #2/3
- submit #1, which needs OWNERS approval which may take me a bit to get

Thoughts? I saw your comments in the bug, I will reply there to discuss.

[wkorman, 2015-06-09 21:18:22]

On 2015/06/09 at 20:57:23, wkorman wrote:
> On 2015/06/09 at 20:49:20, wangxianzhu wrote:
> > Added mac_blink_rel, linux_blink_rel, win_blink_rel try bots to examine
blink failures.
> > 
> > wkorman@ what's your plan before and/or after landing this CL (which will
break blink bots)?
> 
> Thanks, I was going to add those after seeing output of straight CQ since it
was already underway.
> 
> There are basically three things in flight currently:
> 
> 1. This change.
> 2. http://crrev.com/1166223002
> 3. Fixing LayoutTest expectations to go with #2, possibly separate change(s),
or part of #2
> 
> My rough plan was:
> 
> - submit #2/3
> - submit #1, which needs OWNERS approval which may take me a bit to get
> 
> Thoughts? I saw your comments in the bug, I will reply there to discuss.

We'll be faced with some interim breakage on one end or the other re: the rename
of this flag, though, which may be partly what you're getting at. Hmm.

[wkorman, 2015-06-10 00:38:08]

wkorman@chromium.org changed reviewers:
+ jam@chromium.org

[wkorman, 2015-06-10 00:38:08]

+jam for OWNERS approval on the switch change.

Note this change is gated on other changes in flight, see comment thread. We
won't submit this til we've sorted out the Blink-side LayoutTests in particular.

But aiming to get OWNERS feedback so that we are ready with this.

[jam, 2015-06-10 20:07:19]

On 2015/06/10 00:38:08, wkorman wrote:
> +jam for OWNERS approval on the switch change.
> 
> Note this change is gated on other changes in flight, see comment thread. We
> won't submit this til we've sorted out the Blink-side LayoutTests in
particular.
> 
> But aiming to get OWNERS feedback so that we are ready with this.

lgtm

[pdr., 2015-06-10 21:16:05]

pdr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2015-06-10 21:16:06]

lgtm

[chrishtr, 2015-06-10 21:23:56]

lgtm

[wkorman, 2015-06-11 07:00:38]

The CQ bit was checked by wkorman@chromium.org to run a CQ dry run

[wkorman, 2015-06-11 07:00:39]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
enne@chromium.org, chrishtr@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1169193003/#ps100001
(title: "Merge changes.")

[commit-bot: I haz the power, 2015-06-11 07:00:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/100001

[commit-bot: I haz the power, 2015-06-11 08:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 08:19:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wkorman, 2015-06-11 17:48:10]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2015-06-11 17:48:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, jam@chromium.org, pdr@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/1169193003/#ps140001
(title: "Merge changes.")

[commit-bot: I haz the power, 2015-06-11 17:50:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/140001

[commit-bot: I haz the power, 2015-06-11 18:01:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 18:01:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[wkorman, 2015-06-11 18:04:52]

wkorman@chromium.org changed reviewers:
+ aiolos@chromium.org, mpearson@chromium.org

[wkorman, 2015-06-11 18:04:53]

+aiolos -- for OWNERS approval of tools/metrics histograms.xml change (flag
addition related only)
+mpearson -- for OWNERS approval of tools/perf script change to continue perf
testing without slimming paint, follow-up in bug noted in TODO

[Mark P, 2015-06-11 18:34:11]

histograms.xml lgtm

[wkorman, 2015-06-11 18:50:41]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2015-06-11 18:52:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/140001

[commit-bot: I haz the power, 2015-06-11 19:03:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 19:03:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[aiolos (Not reviewing), 2015-06-11 19:49:12]

https://codereview.chromium.org/1169193003/diff/140001/tools/perf/measurement...
File tools/perf/measurements/record_per_area.py (right):

https://codereview.chromium.org/1169193003/diff/140001/tools/perf/measurement...
tools/perf/measurements/record_per_area.py:27: '--disable-slimming-paint'
Two questions:

1) What are you trying to do with this change? Are you wanting to disable
slimming paint on all of the telemetry tests, or just the ones that use this
measurement?

2) Are you planning on using this measurement in tests? No one appears to be
using it in any benchmarks, and I was planning on deleting it.

[wkorman, 2015-06-11 20:12:02]

On 2015/06/11 at 19:49:12, aiolos wrote:
>
https://codereview.chromium.org/1169193003/diff/140001/tools/perf/measurement...
> File tools/perf/measurements/record_per_area.py (right):
> 
>
https://codereview.chromium.org/1169193003/diff/140001/tools/perf/measurement...
> tools/perf/measurements/record_per_area.py:27: '--disable-slimming-paint'
> Two questions:
> 
> 1) What are you trying to do with this change? Are you wanting to disable
slimming paint on all of the telemetry tests, or just the ones that use this
measurement?

Just the ones using this measurement. See:

https://code.google.com/p/chromium/issues/detail?id=498936#c3

> 2) Are you planning on using this measurement in tests? No one appears to be
using it in any benchmarks, and I was planning on deleting it.

We're not using it currently, it should be fine to remove.

[aiolos (Not reviewing), 2015-06-11 20:15:08]

On 2015/06/11 20:12:02, wkorman wrote:
> On 2015/06/11 at 19:49:12, aiolos wrote:
> >
>
https://codereview.chromium.org/1169193003/diff/140001/tools/perf/measurement...
> > File tools/perf/measurements/record_per_area.py (right):
> > 
> >
>
https://codereview.chromium.org/1169193003/diff/140001/tools/perf/measurement...
> > tools/perf/measurements/record_per_area.py:27: '--disable-slimming-paint'
> > Two questions:
> > 
> > 1) What are you trying to do with this change? Are you wanting to disable
> slimming paint on all of the telemetry tests, or just the ones that use this
> measurement?
> 
> Just the ones using this measurement. See:
> 
> https://code.google.com/p/chromium/issues/detail?id=498936#c3
> 
> > 2) Are you planning on using this measurement in tests? No one appears to be
> using it in any benchmarks, and I was planning on deleting it.
> 
> We're not using it currently, it should be fine to remove.

lgtm

[wkorman, 2015-06-11 20:17:06]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2015-06-11 20:17:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/140001

[commit-bot: I haz the power, 2015-06-11 22:21:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 22:21:02]

Try jobs failed on following builders:
  win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)

[wkorman, 2015-06-11 22:55:56]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2015-06-11 22:55:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, jam@chromium.org, mpearson@chromium.org,
enne@chromium.org, aiolos@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1169193003/#ps180001
(title: "Restore perf measurement.")

[commit-bot: I haz the power, 2015-06-11 22:57:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/180001

[commit-bot: I haz the power, 2015-06-11 23:56:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 23:56:57]

Try jobs failed on following builders:
  linux_perf_bisect on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisec...)

[wkorman, 2015-06-12 00:42:21]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2015-06-12 00:42:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, jam@chromium.org, mpearson@chromium.org,
enne@chromium.org, aiolos@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1169193003/#ps200001
(title: "Re-remove measurement.")

[commit-bot: I haz the power, 2015-06-12 00:43:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/200001

[commit-bot: I haz the power, 2015-06-12 00:47:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 00:47:55]

Try jobs failed on following builders:
  mac_perf_bisect on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_perf_bisect/...)

[wkorman, 2015-06-12 01:00:04]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2015-06-12 01:00:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, jam@chromium.org, mpearson@chromium.org,
enne@chromium.org, aiolos@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1169193003/#ps220001
(title: "Merge changes.")

[commit-bot: I haz the power, 2015-06-12 01:01:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/220001

[commit-bot: I haz the power, 2015-06-12 02:20:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 02:20:58]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[wkorman, 2015-06-12 03:58:09]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2015-06-12 03:58:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, jam@chromium.org, mpearson@chromium.org,
enne@chromium.org, aiolos@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1169193003/#ps240001
(title: "Merge changes.")

[commit-bot: I haz the power, 2015-06-12 03:58:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/240001

[commit-bot: I haz the power, 2015-06-12 05:58:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 05:58:46]

Try jobs failed on following builders:
  win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)

[wkorman, 2015-06-12 07:58:36]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2015-06-12 07:58:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, jam@chromium.org, mpearson@chromium.org,
enne@chromium.org, aiolos@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1169193003/#ps260001
(title: "Merge changes.")

[commit-bot: I haz the power, 2015-06-12 07:58:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/260001

[commit-bot: I haz the power, 2015-06-12 09:59:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 09:59:25]

Try jobs failed on following builders:
  win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)

[chrishtr, 2015-06-12 16:08:49]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-06-12 16:09:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/260001

[wkorman, 2015-06-12 17:17:42]

On 2015/06/12 at 16:09:23, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1169193003/260001

Removed perf bisect add'l trybots per note from aiolos@ since we no longer have
perf measurement changes in this change.

[wkorman, 2015-06-12 17:17:54]

The CQ bit was unchecked by wkorman@chromium.org

[wkorman, 2015-06-12 17:17:58]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2015-06-12 17:18:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169193003/260001

[commit-bot: I haz the power, 2015-06-12 17:23:44]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2015-06-12 17:24:43]

Patchset 14 (id:??) landed as
https://crrev.com/af7391ec1e53b6725c1effb51bd83dae54a47568
Cr-Commit-Position: refs/heads/master@{#334188}