Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1261993012: bluetooth: Test for when adapter is not present/off. (Closed)

Created:
5 years, 4 months ago by ortuno
Modified:
5 years, 4 months ago
Reviewers:
Jeffrey Yasskin, scheib
CC:
blink-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@bluetooth-adapter-off
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bluetooth: Test for when adapter is not present/off. Three-way patch to add a message for when Bluetooth Adapter is off: [1] Add constant to public WebBluetoothError. (http://crrev.com/1267843005) [2] Add check for off adapter and add fake adapters. (http://crrev.com/1264323002) [3] This patch. BUG=515573 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200209

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M LayoutTests/bluetooth/requestDevice.html View 1 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
ortuno
@jyasskin: PTAL
5 years, 4 months ago (2015-08-03 23:02:18 UTC) #2
Jeffrey Yasskin
lgtm
5 years, 4 months ago (2015-08-05 20:53:31 UTC) #3
ortuno
@scheib: PTAL
5 years, 4 months ago (2015-08-05 20:59:16 UTC) #5
scheib
LGTM (with upstream patch fixed)
5 years, 4 months ago (2015-08-05 21:36:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261993012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261993012/20001
5 years, 4 months ago (2015-08-08 00:02:32 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-08 02:30:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200209

Powered by Google App Engine
This is Rietveld 408576698