Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1266413003: Get rid of a redundant createLegacyEditingPosition() call in PositionAlgorithm<Strategy>::downstream (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent, yoichio, hajimehoshi
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of a redundant createLegacyEditingPosition() call in PositionAlgorithm<Strategy>::downstream() |createLegacyEditingPosition()|, which returns non-legacy editing position if anchor node returns false for |editingIgnoresContent(node)|, call at L722 is redundant because it takes a node object, which is |!editingIgnoresContent()| by if-statement at L708. This patch replaces a this redundant usage of |createLegacyEditingPosition()| to |PositionAlgorithm<Strategy>| constructor for improving code health. This patch is a similar to http://crrev.com/1262503010, which replaces |createLegacyEditingPosition()| in |PositionAlgorithm<Strategy>::upstream()|. This patch is a preparation of getting rid of legacy editing position. BUG=513114 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199948

Patch Set 1 : 2015-08-04T13:41:34 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/dom/Position.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-04 05:37:01 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-04 06:47:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266413003/1
5 years, 4 months ago (2015-08-04 06:48:20 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 06:51:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199948

Powered by Google App Engine
This is Rietveld 408576698