Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1266723003: Process Public-Key-Pin-Report-Only headers (Closed)

Created:
5 years, 4 months ago by estark
Modified:
5 years, 4 months ago
Reviewers:
davidben, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Sleevi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Process Public-Key-Pin-Report-Only headers This CL adds a call to parse and process HPKP-RO headers in URLRequestHTTPJob. This is based on top of crrev.com/1267513003 BUG=445793 Committed: https://crrev.com/53fee7cfec8bf6426d2ed3d8117ddc08f42e9d87 Cr-Commit-Position: refs/heads/master@{#341563}

Patch Set 1 #

Total comments: 16

Patch Set 2 : rebase #

Patch Set 3 : include includeSubdomains in RO reports #

Patch Set 4 : rsleevi comments #

Total comments: 4

Patch Set 5 : rebase #

Patch Set 6 : davidben comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -64 lines) Patch
M net/http/transport_security_state.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M net/http/transport_security_state.cc View 1 2 3 4 5 3 chunks +71 lines, -20 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 2 3 4 5 9 chunks +165 lines, -42 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
estark
davidben, could you PTAL? This CL follows up on https://codereview.chromium.org/1267513003/ (which parses Report-Only headers).
5 years, 4 months ago (2015-07-30 01:20:20 UTC) #2
Ryan Sleevi
https://codereview.chromium.org/1266723003/diff/1/net/http/transport_security_state.cc File net/http/transport_security_state.cc (right): https://codereview.chromium.org/1266723003/diff/1/net/http/transport_security_state.cc#newcode932 net/http/transport_security_state.cc:932: if (!ssl_info.is_issued_by_known_root) I guess I'm a little nervous to ...
5 years, 4 months ago (2015-07-30 01:52:17 UTC) #4
estark
Thanks, Ryan. https://codereview.chromium.org/1266723003/diff/1/net/http/transport_security_state.cc File net/http/transport_security_state.cc (right): https://codereview.chromium.org/1266723003/diff/1/net/http/transport_security_state.cc#newcode932 net/http/transport_security_state.cc:932: if (!ssl_info.is_issued_by_known_root) On 2015/07/30 01:52:16, Ryan Sleevi ...
5 years, 4 months ago (2015-07-31 00:49:44 UTC) #7
davidben
https://codereview.chromium.org/1266723003/diff/100001/net/http/transport_security_state.cc File net/http/transport_security_state.cc (right): https://codereview.chromium.org/1266723003/diff/100001/net/http/transport_security_state.cc#newcode934 net/http/transport_security_state.cc:934: // root. I think you want "Do not" -> ...
5 years, 4 months ago (2015-07-31 19:45:08 UTC) #8
estark
https://codereview.chromium.org/1266723003/diff/100001/net/http/transport_security_state.cc File net/http/transport_security_state.cc (right): https://codereview.chromium.org/1266723003/diff/100001/net/http/transport_security_state.cc#newcode934 net/http/transport_security_state.cc:934: // root. On 2015/07/31 19:45:07, David Benjamin wrote: > ...
5 years, 4 months ago (2015-07-31 20:37:33 UTC) #9
Ryan Sleevi
lgtm
5 years, 4 months ago (2015-07-31 22:26:47 UTC) #10
davidben
lgtm
5 years, 4 months ago (2015-07-31 22:37:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266723003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266723003/140001
5 years, 4 months ago (2015-08-03 16:49:01 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:140001)
5 years, 4 months ago (2015-08-03 18:31:58 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 18:32:45 UTC) #15
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/53fee7cfec8bf6426d2ed3d8117ddc08f42e9d87
Cr-Commit-Position: refs/heads/master@{#341563}

Powered by Google App Engine
This is Rietveld 408576698