Issue 1333853002: bindings: Moves event handlers and methods of Window to the instance object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1333853002: bindings: Moves event handlers and methods of Window to the instance object. (Closed)

Created:
5 years, 3 months ago by Yuki

Modified:
5 years, 2 months ago

Reviewers:

CC:
blink-reviews, blink-reviews-bindings_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

bindings: Moves event handlers and methods of Window to the instance object. Makes v8_utilities.on_{instance,prototype,interface} conformant to the spec. Moves event handlers and methods on Window from the prototype object to the instance object. Also moves members of [Global] interfaces to the instance objects. BUG=43394, 516274

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Synced. #

Patch Set 4 : Updated test results. #

Patch Set 5 : Updated global-listing test results. #

Patch Set 6 : Synced. #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+917 lines, -703 lines)			Patch
M	LayoutTests/fast/dom/DeviceMotion/window-property-expected.txt	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/DeviceOrientation/window-property-expected.txt	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/Window/lookup-behavior-expected.txt	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
D	LayoutTests/fast/dom/Window/window-property-shadowing-onclick.html	View	1 2 3	1 chunk	+0 lines, -24 lines	0 comments	Download
D	LayoutTests/fast/dom/Window/window-property-shadowing-onclick-expected.txt	View	1 2 3	1 chunk	+0 lines, -13 lines	0 comments	Download
M	LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html	View	1 2 3	2 chunks	+177 lines, -169 lines	0 comments	Download
M	LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt	View	1 2 3	1 chunk	+4 lines, -3 lines	0 comments	Download
M	LayoutTests/http/tests/security/resources/cross-frame-access.js	View	1 2 3	3 chunks	+11 lines, -11 lines	0 comments	Download
M	LayoutTests/http/tests/security/w3c/cross-origin-objects-expected.txt	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/xss-DENIED-method-with-iframe-proto.html	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt	View	1 2 3 4	2 chunks	+30 lines, -27 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/webexposed/resources/global-interface-listing-worker.js	View	1 2 3 4	4 chunks	+54 lines, -19 lines	0 comments	Download
M	LayoutTests/imported/web-platform-tests/html/browsers/the-window-object/window-properties-expected.txt	View	1 2 3	2 chunks	+88 lines, -88 lines	0 comments	Download
M	LayoutTests/imported/web-platform-tests/html/webappapis/animation-frames/idlharness-expected.txt	View	1 2 3	1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt	View	1 2 3 4	2 chunks	+20 lines, -17 lines	0 comments	Download
M	LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt	View	1 2 3 4	2 chunks	+6 lines, -3 lines	0 comments	Download
M	LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt	View	1 2 3 4	2 chunks	+188 lines, -125 lines	0 comments	Download
M	LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt	View	1 2 3 4	2 chunks	+6 lines, -3 lines	0 comments	Download
M	LayoutTests/webexposed/global-interface-listing.html	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt	View	1 2 3 4	2 chunks	+8 lines, -5 lines	0 comments	Download
M	LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt	View	1 2 3 4	2 chunks	+6 lines, -3 lines	0 comments	Download
M	LayoutTests/webexposed/global-interface-listing-expected.txt	View	1 2 3 4	2 chunks	+196 lines, -133 lines	0 comments	Download
M	LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt	View	1 2 3 4	2 chunks	+6 lines, -3 lines	0 comments	Download
M	LayoutTests/webexposed/resources/global-interface-listing.js	View	1 2 3 4	5 chunks	+51 lines, -12 lines	0 comments	Download
M	Source/bindings/scripts/v8_methods.py	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/bindings/scripts/v8_utilities.py	View		4 chunks	+33 lines, -17 lines	0 comments	Download
M	Source/bindings/templates/interface.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/core/V8TestException.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/core/V8TestInterface.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/core/V8TestObject.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/modules/V8TestInterface5.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download