Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1343513002: When rendering offscreen, prefer size 0 instead of 1. (Closed)

Created:
5 years, 3 months ago by cdotstout
Modified:
5 years, 3 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

When rendering offscreen, prefer size 0 instead of 1. Fixes surface creation on ozone/gbm, where pbuffers are not supported. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e5b4b95790bfbc69750a407dba421817644612a3

Patch Set 1 #

Total comments: 4

Patch Set 2 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M services/gles2/command_buffer_driver.cc View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
cdotstout
5 years, 3 months ago (2015-09-11 21:33:50 UTC) #2
jamesr
lgtm https://codereview.chromium.org/1343513002/diff/1/services/gles2/command_buffer_driver.cc File services/gles2/command_buffer_driver.cc (right): https://codereview.chromium.org/1343513002/diff/1/services/gles2/command_buffer_driver.cc#newcode107 services/gles2/command_buffer_driver.cc:107: if (!surface_) add { }s since the body ...
5 years, 3 months ago (2015-09-11 21:34:59 UTC) #3
cdotstout
https://codereview.chromium.org/1343513002/diff/1/services/gles2/command_buffer_driver.cc File services/gles2/command_buffer_driver.cc (right): https://codereview.chromium.org/1343513002/diff/1/services/gles2/command_buffer_driver.cc#newcode107 services/gles2/command_buffer_driver.cc:107: if (!surface_) On 2015/09/11 21:34:59, jamesr wrote: > add ...
5 years, 3 months ago (2015-09-11 21:52:54 UTC) #4
cdotstout
5 years, 3 months ago (2015-09-11 21:57:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e5b4b95790bfbc69750a407dba421817644612a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698