Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1391843004: Add some preprocessor directives to allow compiling without V8. (Closed)

Created:
5 years, 2 months ago by David Lattimore
Modified:
5 years, 2 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add some preprocessor directives to allow compiling without V8. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M fpdfsdk/src/fpdfview.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M samples/pdfium_test.cc View 8 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
David Lattimore
Feel free to send to someone else for review if appropriate.
5 years, 2 months ago (2015-10-08 05:00:34 UTC) #2
Lei Zhang
5 years, 2 months ago (2015-10-08 05:20:50 UTC) #4
Tom Sepez
We'd also need to have GYP/GN variables to allow building this configuration. I think that ...
5 years, 2 months ago (2015-10-08 15:26:36 UTC) #6
Tom Sepez
I'm going to take a stab at this now, since I'm cleaning up JS layer ...
5 years, 2 months ago (2015-10-08 16:52:12 UTC) #7
Tom Sepez
5 years, 2 months ago (2015-10-08 17:17:01 UTC) #8 
On 2015/10/08 16:52:12, Tom Sepez wrote:
> I'm going to take a stab at this now, since I'm cleaning up JS layer anyways.

https://codereview.chromium.org/1395733006/

Powered by Google App Engine
This is Rietveld 408576698