VideoPlayer: Update design of control panel.
This CL updates the design of control panel, but following changes are not included and will be done in following CLs, since this CL is already getting large.
- The progress bar is temporary. I'll replace the custom progress bar with paper-slider.
- The position and format of elapsed time will be updated later.
- Fullscreen icon will be swapped in fullscreen mode.
- I will add ripple effect, using customized one for Files.app (with circle burst) if possible.
BUG=488229
TEST=manually
Committed: https://crrev.com/145fa207ab2678fa34a8f5688fb09070d918bcd5
Cr-Commit-Position: refs/heads/master@{#354455}
5 years, 2 months ago
(2015-10-16 03:58:53 UTC)
#4
Thank you!
https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_playe...
File ui/file_manager/video_player/css/media_controls.css (right):
https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/css/media_controls.css:24: background-color:
rgba(0, 0, 0, 0);
On 2015/10/16 03:19:53, yawano wrote:
> According to the MD guideline, this value seems to be for text color not for
> background color.
I set background-color to prevent disabled buttons from having gray background
on hover/active.
I changed it to transparent to make it clear.
https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/css/media_controls.css:187:
.media-button.play[state='playing'] {
On 2015/10/16 03:19:53, yawano wrote:
> nit: If state='ended' is not used anymore, how about to remove it from
> MediaControls.ButtonStateType of media_controls.js in this CL? Or simply
replace
> it with [playing] attribute?
'ended' and 'paused' share the same icon, but they have different behavior
internally. I'd like to keep the 'ended' state as is.
https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/css/media_controls.css:454:
url(../images/media/media_play_light.png) 1x,
On 2015/10/16 03:19:53, yawano wrote:
> While this might be the issue of code review site, I see the new image of
> media_play_light.png as 1x1px image. Is this correct?
>
>
https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_playe...
Yes, it seems it is a issue of review site.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397683004/20001
5 years, 2 months ago
(2015-10-16 05:39:40 UTC)
#8
5 years, 2 months ago
(2015-10-16 05:46:19 UTC)
#9
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
commit-bot: I haz the power
Failed to apply patch for ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png: While running git rm ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png; fatal: pathspec 'ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png' did ...
5 years, 2 months ago
(2015-10-16 05:46:47 UTC)
#10
Message was sent while issue was closed.
Failed to apply patch for
ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png:
While running git rm
ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png;
fatal: pathspec
'ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png'
did not match any files
Patch: BD
ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/145fa207ab2678fa34a8f5688fb09070d918bcd5 Cr-Commit-Position: refs/heads/master@{#354455}
5 years, 2 months ago
(2015-10-16 05:46:58 UTC)
#11
Issue 1397683004: VideoPlayer: Update design of control panel.
(Closed)
Created 5 years, 2 months ago by fukino
Modified 5 years, 2 months ago
Reviewers: yawano
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 9