Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1397683004: VideoPlayer: Update design of control panel. (Closed)

Created:
5 years, 2 months ago by fukino
Modified:
5 years, 2 months ago
Reviewers:
yawano
CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoPlayer: Update design of control panel. This CL updates the design of control panel, but following changes are not included and will be done in following CLs, since this CL is already getting large. - The progress bar is temporary. I'll replace the custom progress bar with paper-slider. - The position and format of elapsed time will be updated later. - Fullscreen icon will be swapped in fullscreen mode. - I will add ripple effect, using customized one for Files.app (with circle burst) if possible. BUG=488229 TEST=manually Committed: https://crrev.com/145fa207ab2678fa34a8f5688fb09070d918bcd5 Cr-Commit-Position: refs/heads/master@{#354455}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Use transparent instead of rgba(0,0,0,0). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -236 lines) Patch
M ui/file_manager/video_player/css/media_controls.css View 1 9 chunks +45 lines, -222 lines 0 comments Download
M ui/file_manager/video_player/images/media/2x/media_chromecast.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/2x/media_chromecast_casting.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_chromecast_casting_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_chromecast_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_chromecast_hover.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/2x/media_fullscreen.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_fullscreen_disabled.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_fullscreen_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_fullscreen_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_loop.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_loop_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_loop_hover.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/2x/media_pause.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_pause_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_pause_hover.png View Binary file 0 comments Download
A + ui/file_manager/video_player/images/media/2x/media_pause_light.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/2x/media_play.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_play_disabled.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_play_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_play_hover.png View Binary file 0 comments Download
A + ui/file_manager/video_player/images/media/2x/media_play_light.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_disabled.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_disabled_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_disabled_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_full.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_full_disabled.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_full_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_full_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_level1.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_level1_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_level1_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_level2.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_level2_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/2x/media_sound_level2_hover.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/2x/media_volume.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/2x/media_volume_mute.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/media_chromecast.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/media_chromecast_casting.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_chromecast_casting_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_chromecast_casting_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_chromecast_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_chromecast_hover.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/media_fullscreen.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_fullscreen_disabled.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_fullscreen_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_fullscreen_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_loop.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_loop_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_loop_hover.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/media_pause.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_pause_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_pause_hover.png View Binary file 0 comments Download
A + ui/file_manager/video_player/images/media/media_pause_light.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/media_play.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_play_disabled.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_play_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_play_hover.png View Binary file 0 comments Download
A + ui/file_manager/video_player/images/media/media_play_light.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_disabled.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_disabled_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_disabled_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_full.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_full_disabled.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_full_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_full_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_level1.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_level1_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_level1_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_level2.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_level2_down.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/media/media_sound_level2_hover.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/media_volume.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/media_volume_mute.png View Binary file 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
fukino
PTAL. Thanks! https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_player/css/media_controls.css File ui/file_manager/video_player/css/media_controls.css (right): https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_player/css/media_controls.css#newcode16 ui/file_manager/video_player/css/media_controls.css:16: background-color: rgba(153, 153, 153, 0.2); Style for ...
5 years, 2 months ago (2015-10-15 16:08:58 UTC) #2
yawano
https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_player/css/media_controls.css File ui/file_manager/video_player/css/media_controls.css (right): https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_player/css/media_controls.css#newcode24 ui/file_manager/video_player/css/media_controls.css:24: background-color: rgba(0, 0, 0, 0); According to the MD ...
5 years, 2 months ago (2015-10-16 03:19:53 UTC) #3
fukino
Thank you! https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_player/css/media_controls.css File ui/file_manager/video_player/css/media_controls.css (right): https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_player/css/media_controls.css#newcode24 ui/file_manager/video_player/css/media_controls.css:24: background-color: rgba(0, 0, 0, 0); On 2015/10/16 ...
5 years, 2 months ago (2015-10-16 03:58:53 UTC) #4
yawano
lgtm. Thank you! https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_player/css/media_controls.css File ui/file_manager/video_player/css/media_controls.css (right): https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_player/css/media_controls.css#newcode24 ui/file_manager/video_player/css/media_controls.css:24: background-color: rgba(0, 0, 0, 0); Yes, ...
5 years, 2 months ago (2015-10-16 04:53:49 UTC) #5
fukino
On 2015/10/16 04:53:49, yawano wrote: > lgtm. Thank you! > > https://codereview.chromium.org/1397683004/diff/1/ui/file_manager/video_player/css/media_controls.css > File ui/file_manager/video_player/css/media_controls.css ...
5 years, 2 months ago (2015-10-16 05:39:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397683004/20001
5 years, 2 months ago (2015-10-16 05:39:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-16 05:46:19 UTC) #9
commit-bot: I haz the power
Failed to apply patch for ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png: While running git rm ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png; fatal: pathspec 'ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png' did ...
5 years, 2 months ago (2015-10-16 05:46:47 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 05:46:58 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/145fa207ab2678fa34a8f5688fb09070d918bcd5
Cr-Commit-Position: refs/heads/master@{#354455}

Powered by Google App Engine
This is Rietveld 408576698