Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1400183002: VideoPlayer: Use system header. (Closed)

Created:
5 years, 2 months ago by fukino
Modified:
5 years, 2 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoPlayer: Use system header. BUG=488229 TEST=manually Committed: https://crrev.com/e4471ed4dce8f2fc53e3e7f54aa8c4e18b93ea8c Cr-Commit-Position: refs/heads/master@{#354220}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Corrected header color. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -129 lines) Patch
D ui/file_manager/video_player/css/header.css View 1 chunk +0 lines, -88 lines 0 comments Download
M ui/file_manager/video_player/js/background.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 2 chunks +0 lines, -33 lines 0 comments Download
M ui/file_manager/video_player/video_player.html View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
fukino
PTAL. Thanks!
5 years, 2 months ago (2015-10-13 12:26:44 UTC) #2
yawano
https://codereview.chromium.org/1400183002/diff/1/ui/file_manager/video_player/js/background.js File ui/file_manager/video_player/js/background.js (left): https://codereview.chromium.org/1400183002/diff/1/ui/file_manager/video_player/js/background.js#oldcode20 ui/file_manager/video_player/js/background.js:20: frame: 'none', Could you confirm that header color of ...
5 years, 2 months ago (2015-10-14 09:26:55 UTC) #3
fukino
https://codereview.chromium.org/1400183002/diff/1/ui/file_manager/video_player/js/background.js File ui/file_manager/video_player/js/background.js (left): https://codereview.chromium.org/1400183002/diff/1/ui/file_manager/video_player/js/background.js#oldcode20 ui/file_manager/video_player/js/background.js:20: frame: 'none', On 2015/10/14 09:26:54, yawano wrote: > Could ...
5 years, 2 months ago (2015-10-15 03:56:40 UTC) #4
yawano
lgtm. Thank you!
5 years, 2 months ago (2015-10-15 03:58:59 UTC) #5
yawano
On 2015/10/15 03:58:59, yawano wrote: > lgtm. Thank you! very small nit: please update the ...
5 years, 2 months ago (2015-10-15 04:00:34 UTC) #6
fukino
On 2015/10/15 04:00:34, yawano wrote: > On 2015/10/15 03:58:59, yawano wrote: > > lgtm. Thank ...
5 years, 2 months ago (2015-10-15 04:04:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400183002/20001
5 years, 2 months ago (2015-10-15 04:06:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 04:36:54 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 04:37:48 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e4471ed4dce8f2fc53e3e7f54aa8c4e18b93ea8c
Cr-Commit-Position: refs/heads/master@{#354220}

Powered by Google App Engine
This is Rietveld 408576698