Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 1404923003: VideoPlayer: Remove unused AudioControl class. (Closed)

Created:
5 years, 2 months ago by fukino
Modified:
5 years, 2 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoPlayer: Remove unused AudioControl class. BUG=none TEST=none Committed: https://crrev.com/f5178b9c461db1349b64a1618efa765d7a984570 Cr-Commit-Position: refs/heads/master@{#354283}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -74 lines) Patch
M ui/file_manager/video_player/js/media_controls.js View 4 chunks +4 lines, -74 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
fukino
Yoshiki-san, could you take a look at this simple removal of unused AudioControl? https://codereview.chromium.org/1404923003/diff/1/ui/file_manager/video_player/js/media_controls.js File ...
5 years, 2 months ago (2015-10-15 12:45:05 UTC) #2
yoshiki
LGTM. Thanks.
5 years, 2 months ago (2015-10-15 16:13:05 UTC) #3
fukino
On 2015/10/15 16:13:05, yoshiki wrote: > LGTM. Thanks. Thank you!
5 years, 2 months ago (2015-10-15 16:14:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404923003/1
5 years, 2 months ago (2015-10-15 16:15:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 16:52:31 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 16:53:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5178b9c461db1349b64a1618efa765d7a984570
Cr-Commit-Position: refs/heads/master@{#354283}

Powered by Google App Engine
This is Rietveld 408576698