Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1405993008: compositor-worker: plumb element id and mutable properties (Closed)

Created:
5 years, 1 month ago by Ian Vollick
Modified:
4 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, sof, szager+layoutwatch_chromium.org, vmpstr+blinkwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

compositor-worker: plumb element id and mutable properties For proxied elements, this CL ensures that the element id and mutable property bitfield are propagated to the compositor. BUG=430155 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/933f496ec9750765871f21d74a3c48eb23c5eb86 Cr-Commit-Position: refs/heads/master@{#363737}

Patch Set 1 #

Patch Set 2 : Fixed layout test (and logged bug) #

Total comments: 4

Patch Set 3 : remove unused variable and redundant assertion. #

Patch Set 4 : Add static asserts for mutable properties enum. s/ASSERT/EXPECT/ in unit test. #

Total comments: 1

Patch Set 5 : Added a FIXME to buggy code. #

Patch Set 6 : teach main about proxied properties #

Patch Set 7 : rebase #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : oh no i included a file that i shouldn't have #

Patch Set 12 : fix bug in CompositorProxy::supports #

Patch Set 13 : s/WebMutable/WebCompositorMutable/g #

Total comments: 20

Patch Set 14 : . #

Patch Set 15 : respond to reviewer feedback #

Patch Set 16 : compositor proxies no longer imply will-change :( #

Patch Set 17 : fix another media track layout test. #

Total comments: 4

Patch Set 18 : . #

Total comments: 24

Patch Set 19 : . #

Patch Set 20 : address reviewer feedback #

Patch Set 21 : rebase #

Total comments: 6

Patch Set 22 : Address reviewer feedback #

Patch Set 23 : rebase #

Patch Set 24 : fix rebase error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+905 lines, -104 lines) Patch
A cc/animation/mutable_properties.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +20 lines, -0 lines 0 comments Download
M cc/blink/web_layer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +4 lines, -0 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +47 lines, -0 lines 0 comments Download
M cc/layers/layer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +8 lines, -0 lines 0 comments Download
M cc/layers/layer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 4 chunks +25 lines, -0 lines 0 comments Download
M cc/layers/layer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +8 lines, -0 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 5 chunks +32 lines, -0 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 3 chunks +9 lines, -3 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +26 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-word-breaking.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-supports.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/CompositorProxiedPropertySet.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/CompositorProxiedPropertySet.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +55 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +6 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 10 chunks +62 lines, -59 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +22 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 7 chunks +28 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +215 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/compositor-proxy-basic.html View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/compositor-proxy-basic-disconnected.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/compositor-proxy-plumbing-no-proxies.html View 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebCompositorMutableProperties.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 53 (17 generated)
Ian Vollick
5 years, 1 month ago (2015-11-08 02:08:58 UTC) #2
danakj
-dana +enne
5 years, 1 month ago (2015-11-09 19:20:29 UTC) #5
enne (OOO)
https://codereview.chromium.org/1405993008/diff/20001/cc/animation/mutable_properties.h File cc/animation/mutable_properties.h (right): https://codereview.chromium.org/1405993008/diff/20001/cc/animation/mutable_properties.h#newcode10 cc/animation/mutable_properties.h:10: enum MutableProperty { Kind of sad this has to ...
5 years, 1 month ago (2015-11-10 00:11:41 UTC) #6
Ian Vollick
https://codereview.chromium.org/1405993008/diff/20001/cc/animation/mutable_properties.h File cc/animation/mutable_properties.h (right): https://codereview.chromium.org/1405993008/diff/20001/cc/animation/mutable_properties.h#newcode10 cc/animation/mutable_properties.h:10: enum MutableProperty { On 2015/11/10 00:11:41, enne wrote: > ...
5 years, 1 month ago (2015-11-10 20:30:14 UTC) #7
enne (OOO)
Thanks! cc lgtm
5 years, 1 month ago (2015-11-10 20:34:25 UTC) #8
Ian Vollick
On 2015/11/10 20:34:25, enne wrote: > Thanks! > > cc lgtm thanks :) esprehn, ping. ...
5 years, 1 month ago (2015-11-10 22:27:37 UTC) #10
esprehn
Yeah I'm looking. To unsubscribe from this group and stop receiving emails from it, send ...
5 years, 1 month ago (2015-11-11 01:08:31 UTC) #11
esprehn
Yeah I'm looking. To unsubscribe from this group and stop receiving emails from it, send ...
5 years, 1 month ago (2015-11-11 01:16:09 UTC) #12
Ian Vollick
https://codereview.chromium.org/1405993008/diff/60001/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp File third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp (right): https://codereview.chromium.org/1405993008/diff/60001/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp#newcode199 third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp:199: style.setWillChangeProperties(properties); trchen@ just pointed out that this is wrong. ...
5 years, 1 month ago (2015-11-11 01:36:33 UTC) #13
trchen
On 2015/11/11 01:36:33, vollick wrote: > https://codereview.chromium.org/1405993008/diff/60001/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > File third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp (right): > > https://codereview.chromium.org/1405993008/diff/60001/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp#newcode199 > ...
5 years, 1 month ago (2015-11-11 22:50:36 UTC) #14
Ian Vollick
Elliott, I've added code to track which properties are proxied on the main thread, so ...
5 years, 1 month ago (2015-11-13 02:54:15 UTC) #15
Ian Vollick
esprehn, I've renamed the stuff in the blink namespace from WebMutable* to WebCompositorMutable* as we'd ...
5 years, 1 month ago (2015-11-17 20:07:07 UTC) #16
ajuma
https://codereview.chromium.org/1405993008/diff/240001/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp File third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp (right): https://codereview.chromium.org/1405993008/diff/240001/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp#newcode191 third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp:191: style.setWillChangeScrollPosition(true); will-change:scroll-position doesn't currently create a composited layer (or ...
5 years, 1 month ago (2015-11-20 21:55:27 UTC) #18
Ian Vollick
https://codereview.chromium.org/1405993008/diff/240001/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp File third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp (right): https://codereview.chromium.org/1405993008/diff/240001/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp#newcode191 third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp:191: style.setWillChangeScrollPosition(true); On 2015/11/20 21:55:27, ajuma wrote: > will-change:scroll-position doesn't ...
5 years ago (2015-11-23 20:25:55 UTC) #19
chrishtr
https://codereview.chromium.org/1405993008/diff/240001/cc/animation/mutable_properties.h File cc/animation/mutable_properties.h (right): https://codereview.chromium.org/1405993008/diff/240001/cc/animation/mutable_properties.h#newcode16 cc/animation/mutable_properties.h:16: kMutablePropertyTransformRelated = kMutablePropertyTransform | Unused? https://codereview.chromium.org/1405993008/diff/240001/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp File third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp (right): ...
5 years ago (2015-11-24 16:22:50 UTC) #20
Ian Vollick
Thanks for the review! https://codereview.chromium.org/1405993008/diff/240001/cc/animation/mutable_properties.h File cc/animation/mutable_properties.h (right): https://codereview.chromium.org/1405993008/diff/240001/cc/animation/mutable_properties.h#newcode16 cc/animation/mutable_properties.h:16: kMutablePropertyTransformRelated = kMutablePropertyTransform | On ...
5 years ago (2015-11-25 18:28:45 UTC) #21
ajuma
lgtm
5 years ago (2015-11-25 19:40:09 UTC) #22
Ian Vollick
On 2015/11/25 19:40:09, ajuma wrote: > lgtm chrishtr, ping.
5 years ago (2015-12-01 22:15:25 UTC) #23
chrishtr
https://codereview.chromium.org/1405993008/diff/320001/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp File third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp (right): https://codereview.chromium.org/1405993008/diff/320001/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp#newcode395 third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp:395: if (RuntimeEnabledFeatures::compositorWorkerEnabled() && m_scrollLayer) { Is there a testcase ...
5 years ago (2015-12-01 23:17:03 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405993008/340001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405993008/340001
5 years ago (2015-12-02 00:37:44 UTC) #26
Ian Vollick
https://codereview.chromium.org/1405993008/diff/320001/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp File third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp (right): https://codereview.chromium.org/1405993008/diff/320001/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp#newcode395 third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp:395: if (RuntimeEnabledFeatures::compositorWorkerEnabled() && m_scrollLayer) { On 2015/12/01 23:17:03, chrishtr ...
5 years ago (2015-12-02 00:39:33 UTC) #27
chrishtr
lgtm
5 years ago (2015-12-02 00:49:26 UTC) #28
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 02:27:39 UTC) #30
Ian Vollick
On 2015/12/02 02:27:39, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-12-02 02:39:10 UTC) #32
esprehn
https://codereview.chromium.org/1405993008/diff/340001/third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html File third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html (right): https://codereview.chromium.org/1405993008/diff/340001/third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html#newcode10 third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html:10: window.internals.settings.setCompositorWorkerEnabled(false); sigh, this is really awful. We need to ...
5 years ago (2015-12-02 03:28:49 UTC) #34
haraken
bindings/ and web/ LGTM
5 years ago (2015-12-02 04:04:13 UTC) #35
Ian Vollick
https://codereview.chromium.org/1405993008/diff/340001/third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html File third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html (right): https://codereview.chromium.org/1405993008/diff/340001/third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html#newcode10 third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html:10: window.internals.settings.setCompositorWorkerEnabled(false); On 2015/12/02 03:28:48, esprehn wrote: > sigh, this ...
5 years ago (2015-12-03 17:54:43 UTC) #36
Ian Vollick
https://codereview.chromium.org/1405993008/diff/340001/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp File third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp (right): https://codereview.chromium.org/1405993008/diff/340001/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp#newcode1388 third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp:1388: Node* node = layer->enclosingElement(); On 2015/12/03 17:54:43, vollick wrote: ...
5 years ago (2015-12-03 22:33:02 UTC) #37
Ian Vollick
On 2015/12/03 22:33:02, vollick wrote: > https://codereview.chromium.org/1405993008/diff/340001/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp > File third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp (right): > > https://codereview.chromium.org/1405993008/diff/340001/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp#newcode1388 > ...
5 years ago (2015-12-04 15:29:55 UTC) #38
esprehn
lgtm https://codereview.chromium.org/1405993008/diff/400001/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-supports.html File third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-supports.html (right): https://codereview.chromium.org/1405993008/diff/400001/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-supports.html#newcode3 third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-supports.html:3: --> remove comment? https://codereview.chromium.org/1405993008/diff/400001/third_party/WebKit/Source/core/dom/CompositorProxy.cpp File third_party/WebKit/Source/core/dom/CompositorProxy.cpp (right): https://codereview.chromium.org/1405993008/diff/400001/third_party/WebKit/Source/core/dom/CompositorProxy.cpp#newcode35 ...
5 years ago (2015-12-07 20:54:24 UTC) #40
Ian Vollick
https://codereview.chromium.org/1405993008/diff/400001/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-supports.html File third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-supports.html (right): https://codereview.chromium.org/1405993008/diff/400001/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-supports.html#newcode3 third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-supports.html:3: --> On 2015/12/07 20:54:24, esprehn wrote: > remove comment? ...
5 years ago (2015-12-08 00:16:44 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405993008/440001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405993008/440001
5 years ago (2015-12-08 00:21:29 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/132984) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-08 00:25:31 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405993008/460001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405993008/460001
5 years ago (2015-12-08 03:13:39 UTC) #49
commit-bot: I haz the power
Committed patchset #24 (id:460001)
5 years ago (2015-12-08 04:22:13 UTC) #51
commit-bot: I haz the power
5 years ago (2015-12-08 04:23:29 UTC) #53
Message was sent while issue was closed.
Patchset 24 (id:??) landed as
https://crrev.com/933f496ec9750765871f21d74a3c48eb23c5eb86
Cr-Commit-Position: refs/heads/master@{#363737}

Powered by Google App Engine
This is Rietveld 408576698