Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1406163006: Composited Animations Tests: Support compositorAnimationTimelinesEnabled mode. (Closed)

Created:
5 years, 1 month ago by loyso (OOO)
Modified:
5 years, 1 month ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Composited Animations Tests: Support compositorAnimationTimelinesEnabled mode. We want to enable compositor animation timelines (external cc::AnimationHost) mode by default here: https://codereview.chromium.org/1308053006/ So we need platform's compositorSupport object initialized _before_ document and timeline creation. BUG=394777 Committed: https://crrev.com/20a10d4be7e35624e75f319516aeb13b46ecbfcd Cr-Commit-Position: refs/heads/master@{#360005}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -58 lines) Patch
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 36 chunks +33 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
loyso (OOO)
5 years, 1 month ago (2015-11-05 04:34:07 UTC) #3
loyso (OOO)
On 2015/11/05 04:34:07, loyso wrote: PTAL!
5 years, 1 month ago (2015-11-12 20:17:57 UTC) #6
dstockwell
lgtm
5 years, 1 month ago (2015-11-16 23:08:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406163006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406163006/1
5 years, 1 month ago (2015-11-16 23:11:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/58029)
5 years, 1 month ago (2015-11-16 23:19:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406163006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406163006/40001
5 years, 1 month ago (2015-11-17 04:38:25 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-17 05:01:12 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 05:02:11 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20a10d4be7e35624e75f319516aeb13b46ecbfcd
Cr-Commit-Position: refs/heads/master@{#360005}

Powered by Google App Engine
This is Rietveld 408576698