Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1407373006: [Sync] Componentize SyncBackendHost{Impl,Core,Mock}. (Closed)

Created:
5 years, 1 month ago by maxbogue
Modified:
5 years, 1 month ago
Reviewers:
Nicolas Zea, sclittle
CC:
chromium-reviews, tim+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, zea+watch_chromium.org, blundell+watchlist_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sbhi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Componentize SyncBackendHost{Impl,Core,Mock}. BUG=512056, 512059 Committed: https://crrev.com/de41d67b0b37d48f1107141c1479417fee37e3c7 Cr-Commit-Position: refs/heads/master@{#358403}

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 1

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -2946 lines) Patch
D chrome/browser/sync/glue/sync_backend_host.h View 1 chunk +0 lines, -235 lines 0 comments Download
D chrome/browser/sync/glue/sync_backend_host.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/sync/glue/sync_backend_host_core.h View 1 chunk +0 lines, -332 lines 0 comments Download
D chrome/browser/sync/glue/sync_backend_host_core.cc View 1 chunk +0 lines, -791 lines 0 comments Download
D chrome/browser/sync/glue/sync_backend_host_impl.h View 1 chunk +0 lines, -378 lines 0 comments Download
D chrome/browser/sync/glue/sync_backend_host_impl.cc View 1 chunk +0 lines, -865 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/sync/glue/sync_backend_host_mock.h View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/browser/sync/glue/sync_backend_host_mock.cc View 1 chunk +0 lines, -156 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/test_profile_sync_service.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync_driver.gypi View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M components/sync_driver/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/sync_driver/glue/sync_backend_host.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + components/sync_driver/glue/sync_backend_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sync_driver/glue/sync_backend_host_core.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/sync_driver/glue/sync_backend_host_core.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/sync_driver/glue/sync_backend_host_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sync_driver/glue/sync_backend_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sync_driver/glue/sync_backend_host_mock.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/sync_driver/glue/sync_backend_host_mock.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
maxbogue
Nicolas, PTAL!
5 years, 1 month ago (2015-11-04 20:05:17 UTC) #2
Nicolas Zea
LGTM! https://codereview.chromium.org/1407373006/diff/20001/components/sync_driver/glue/sync_backend_host.h File components/sync_driver/glue/sync_backend_host.h (right): https://codereview.chromium.org/1407373006/diff/20001/components/sync_driver/glue/sync_backend_host.h#newcode230 components/sync_driver/glue/sync_backend_host.h:230: private: nice catch!
5 years, 1 month ago (2015-11-05 23:35:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407373006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407373006/20001
5 years, 1 month ago (2015-11-05 23:39:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/90850) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-05 23:43:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407373006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407373006/40001
5 years, 1 month ago (2015-11-05 23:59:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/116112)
5 years, 1 month ago (2015-11-06 00:20:19 UTC) #12
maxbogue
+sclittle for the new dep on components/data_use_measurement/core
5 years, 1 month ago (2015-11-06 00:22:40 UTC) #14
sclittle
components/data_use_measurement in DEPS lgtm
5 years, 1 month ago (2015-11-06 19:07:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407373006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407373006/40001
5 years, 1 month ago (2015-11-06 20:54:33 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-06 21:21:15 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 21:23:01 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/de41d67b0b37d48f1107141c1479417fee37e3c7
Cr-Commit-Position: refs/heads/master@{#358403}

Powered by Google App Engine
This is Rietveld 408576698