Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issue 1409083002: Reset Signin state both before and after signin tests. (Closed)

Created:
5 years, 2 months ago by knn
Modified:
5 years, 2 months ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset Signin state both before and after signin tests. We assume a account id <-> name mapping is available for accounts in the token service as well as for the signed in account. This will eliminate some illegal signin states after running the tests. BUG=542962, 535211 Committed: https://crrev.com/d966e6f1df247a39ddafab5f80956bf464c9b1a3 Cr-Commit-Position: refs/heads/master@{#354511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/signin/SigninTestUtil.java View 3 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
knn
PTAL. Thanks!
5 years, 2 months ago (2015-10-16 12:12:42 UTC) #2
nyquist
lgtm
5 years, 2 months ago (2015-10-16 13:50:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409083002/1
5 years, 2 months ago (2015-10-16 13:51:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 14:07:21 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 14:08:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d966e6f1df247a39ddafab5f80956bf464c9b1a3
Cr-Commit-Position: refs/heads/master@{#354511}

Powered by Google App Engine
This is Rietveld 408576698