Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1410873003: CC Animations: Fix isThreadedAnimationEnabled mode for layout tests (Closed)

Created:
5 years, 2 months ago by loyso (OOO)
Modified:
5 years, 1 month ago
Reviewers:
Ian Vollick, pdr., chrishtr
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animations: Fix isThreadedAnimationEnabled mode for layout tests Distinguish three modes for CC compositor animation timelines (CC AnimationHost) 1) AnimationHost disabled: No players, no timelines. 2) AnimationHost enabled in --enable-threaded-compositing mode: Create players, create timelines. 3) AnimationHost enabled without --enable-threaded-compositing mode (--disable-threaded-animation mode): Create players, do not create timelines. ProgrammaticScrollAnimator already supports the case when timeline is nullptr. BUG=545332 Committed: https://crrev.com/4c44bddab18803749299a912907601acff719911 Cr-Commit-Position: refs/heads/master@{#356006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
loyso (OOO)
5 years, 2 months ago (2015-10-19 04:21:06 UTC) #2
loyso (OOO)
5 years, 2 months ago (2015-10-19 04:31:38 UTC) #3
Ian Vollick
On 2015/10/19 04:31:38, loyso wrote: This seems straightforward. lgtm.
5 years, 2 months ago (2015-10-20 05:16:36 UTC) #4
loyso (OOO)
chrishtr@, friendly ping!
5 years, 2 months ago (2015-10-21 06:17:57 UTC) #8
loyso (OOO)
pdr@, could you take a look? Thanks!
5 years, 1 month ago (2015-10-26 00:07:24 UTC) #10
pdr.
lgtm
5 years, 1 month ago (2015-10-26 02:30:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410873003/1
5 years, 1 month ago (2015-10-26 02:37:50 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 03:29:21 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 03:30:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c44bddab18803749299a912907601acff719911
Cr-Commit-Position: refs/heads/master@{#356006}

Powered by Google App Engine
This is Rietveld 408576698