CC Animations: Fix AnimationHost mode integration with Property Trees.

CC Animations: Fix AnimationHost mode integration with Property Trees.

Fix the test:
content_shell --run-layout-test --enable-threaded-compositing transitions/3d/interrupted-transition.html

1) Invalidate property trees in AnimationPlayer::SetNeedsCommit (as in Layer::SetNeedsCommit).

2) We simply destroy AnimationPlayers on interruptions.
We destroy Layer Animation Controller if no AnimationPlayers for this layer (despite animations it may be running).
So let's clear is_animated flags in property trees on LAC destruction.

BUG=545332
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d02fc478259f5a1e3208d4c26ef8f3b1f2681499
Cr-Commit-Position: refs/heads/master@{#355288}

[loyso (OOO), 2015-10-19 05:42:27]

loyso@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org

[ajuma, 2015-10-19 13:15:28]

This looks good, but please add a LayerTreeHostTimelinesTest for this (that
fails property tree verification before your patch).

[loyso (OOO), 2015-10-20 05:44:43]

Description was changed from

==========
CC Animations: Fix AnimationHost mode integration with Property Trees.

Fix the test:
content_shell --run-layout-test --enable-threaded-compositing
transitions/3d/interrupted-transition.html

1) Invalidate property trees in AnimationPlayer::SetNeedsCommit (as in
Layer::SetNeedsCommit).

2) We simply destroy AnimationPlayers on interruptions.
We destroy Layer Animation Controller if no AnimationPlayers for this layer
(despite animations it may be running).
So let's clear is_animated flags in property trees on LAC destruction.

BUG=394777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animations: Fix AnimationHost mode integration with Property Trees.

Fix the test:
content_shell --run-layout-test --enable-threaded-compositing
transitions/3d/interrupted-transition.html

1) Invalidate property trees in AnimationPlayer::SetNeedsCommit (as in
Layer::SetNeedsCommit).

2) We simply destroy AnimationPlayers on interruptions.
We destroy Layer Animation Controller if no AnimationPlayers for this layer
(despite animations it may be running).
So let's clear is_animated flags in property trees on LAC destruction.

BUG=545332
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2015-10-20 05:45:13]

On 2015/10/19 13:15:28, ajuma wrote:
> This looks good, but please add a LayerTreeHostTimelinesTest for this (that
> fails property tree verification before your patch).
Ok. trying to reproduce that flakiness in the unit test.

[loyso (OOO), 2015-10-21 03:00:40]

On 2015/10/19 13:15:28, ajuma wrote:
> This looks good, but please add a LayerTreeHostTimelinesTest for this (that
> fails property tree verification before your patch).
Done. PTAL!

[ajuma, 2015-10-21 14:21:28]

On 2015/10/21 03:00:40, loyso wrote:
> On 2015/10/19 13:15:28, ajuma wrote:
> > This looks good, but please add a LayerTreeHostTimelinesTest for this (that
> > fails property tree verification before your patch).
> Done. PTAL!

lgtm

[ajuma, 2015-10-21 14:21:33]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2015-10-21 14:21:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413003002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413003002/80001

[commit-bot: I haz the power, 2015-10-21 14:26:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-21 14:27:25]

Patchset 5 (id:??) landed as
https://crrev.com/d02fc478259f5a1e3208d4c26ef8f3b1f2681499
Cr-Commit-Position: refs/heads/master@{#355288}