Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1420913008: CC AnimationHost: Fix ProgrammaticScrollAnimator detach scope. (Closed)

Created:
5 years, 1 month ago by loyso (OOO)
Modified:
5 years, 1 month ago
CC:
darktears, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, kenneth.christiansen, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC AnimationHost: Fix ProgrammaticScrollAnimator detach scope. In a new world with external cc::AnimationHost blink::WebCompositorAnimationPlayer objects may outsurvive the compositor (LayerTreeView and AnimationHost). In this case, they become detached. (See RenderWidget::Close()) In general, any subsystem can react on willCloseLayerTreeView if some actions required before detach. See the related fix for LinkHighlights here: https://codereview.chromium.org/1413373007/ BUG=541069 Committed: https://crrev.com/f59fdc1d0bc0eb35382f59f7e5f89a66bd0c325d Cr-Commit-Position: refs/heads/master@{#357551}

Patch Set 1 #

Messages

Total messages: 12 (5 generated)
loyso (OOO)
5 years, 1 month ago (2015-11-03 04:29:53 UTC) #2
loyso (OOO)
A LayoutTests OWNER needed for review. Any recommendations, please?
5 years, 1 month ago (2015-11-03 04:33:23 UTC) #4
jochen (gone - plz use gerrit)
layout tests are owned by everybody: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/LayoutTests/OWNERS&l=1 I'm not a good reviewer for the actual ...
5 years, 1 month ago (2015-11-03 07:25:04 UTC) #7
chrishtr
lgtm
5 years, 1 month ago (2015-11-03 16:18:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420913008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420913008/1
5 years, 1 month ago (2015-11-03 16:19:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 18:16:38 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 18:18:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f59fdc1d0bc0eb35382f59f7e5f89a66bd0c325d
Cr-Commit-Position: refs/heads/master@{#357551}

Powered by Google App Engine
This is Rietveld 408576698