Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 143503004: Revert "Revert 249234 "Use MessagePumpDispatcher instead of MessageFilter"" (Closed)

Created:
6 years, 10 months ago by yukawa
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert "Revert 249234 "Use MessagePumpDispatcher instead of MessageFilter"" This reverts commit 33c0f57d77e38a009034fb7d0e905755d9620035 with a trivial modification to corp with a recent refactoring committed as r249105. BUG=330735, 319122 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249650

Patch Set 1 : r249234 #

Patch Set 2 : Stop using base::RunLoop::set_dispatcher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M cloud_print/service/win/cloud_print_service_config.cc View 1 3 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yukawa
Hi Vitaly, This is the second try. The previous compile error we observed is turned ...
6 years, 10 months ago (2014-02-07 03:39:13 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 10 months ago (2014-02-07 03:55:09 UTC) #2
yukawa
The CQ bit was checked by yukawa@chromium.org
6 years, 10 months ago (2014-02-07 03:56:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/143503004/100001
6 years, 10 months ago (2014-02-07 03:56:45 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 09:16:34 UTC) #5
Message was sent while issue was closed.
Change committed as 249650

Powered by Google App Engine
This is Rietveld 408576698