Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 145283006: Remove ui::TextInputClient::GetAttachedWindow

Created:
6 years, 10 months ago by yukawa
Modified:
6 years, 10 months ago
Reviewers:
CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove ui::TextInputClient::GetAttachedWindow This CL logically reverts r204060, which is no longer used in the era of Aura. It was originally introduced as a tentative solution until Aura transition is completed on Windows. Now we can safely revert that change. BUG=330735, 319122

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ime/dummy_text_input_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/ime/input_method_chromeos_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/base/ime/text_input_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/controls/prefix_selector.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/prefix_selector.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M ui/views/ime/input_method_bridge.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/ime/input_method_bridge.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698