Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1456303002: CC Animations: Allow AnimationPlayers attached to layers but not attached to timelines/host to die … (Closed)

Created:
5 years, 1 month ago by loyso (OOO)
Modified:
5 years, 1 month ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animations: Allow AnimationPlayers attached to layers but not attached to timelines/host to die without DCHECK. Otherwise it fails the following webkit_unit_test: PaintPropertyTreeBuilderTest.FrameScrollingTraditional (PaintPropertyTreeBuilderTest.cpp:103) We want to enable compositor animation timelines (external cc::AnimationHost) mode by default here: https://codereview.chromium.org/1308053006/ BUG=394777 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/67ed6fa1730bec91dbbdbf35fc6af9cdd3b61721 Cr-Commit-Position: refs/heads/master@{#360724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M cc/animation/animation_player.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
loyso (OOO)
5 years, 1 month ago (2015-11-19 03:14:05 UTC) #2
ajuma
lgtm
5 years, 1 month ago (2015-11-19 14:07:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456303002/1
5 years, 1 month ago (2015-11-19 22:41:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-20 00:48:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456303002/1
5 years, 1 month ago (2015-11-20 02:27:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 02:38:19 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 02:39:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67ed6fa1730bec91dbbdbf35fc6af9cdd3b61721
Cr-Commit-Position: refs/heads/master@{#360724}

Powered by Google App Engine
This is Rietveld 408576698