Add LayoutTests/FlagExpectations directory for flag-specific expectations.

Add LayoutTests/FlagExpectations directory for flag-specific expectations.

Committed: https://crrev.com/44e1d1f35b8402ffaf4e7bf3e0ef9c29b196c763
Cr-Commit-Position: refs/heads/master@{#361584}

[skobes, 2015-11-20 19:48:53]

skobes@chromium.org changed reviewers:
+ ojan@chromium.org

[skobes, 2015-11-20 19:48:54]

My primary motivation for this patch is to have a record in the tree of which
layout tests fail with root layer scrolling.  RLS patches can remove lines from
FlagExpectations/root-layer-scrolls as evidence of test coverage.

This avoids the need to add virtual test suites for the entire world, which
doesn't scale (as slimming paint discovered).

Verification and gardening will be manual for now (I might set up a cron job on
my workstation).  But if regressions are common I suppose we could try to get a
dedicated root layer scrolling bot set up.

The new behavior in run-webkit-tests is not strictly necessary since it already
has the --additional-expectations flag, but I think it is good for convenience
and usability.

[ojan, 2015-11-20 19:57:53]

OMG. I <3 this.

Mind sending a PSA to blink-dev soliciting thoughts on pros and cons of this
approach so we can think it through and see if there are any issues we're not
thinking of? We don't need blink-dev's permission or anything...just worth
soliciting as much feedback as we can to make sure we build the best thing.

Off the top of my head, this looks great to land as is.

+dpranke, wangxianzhu, pdr, jsbell. They've all had opinions on layout testing
infra in the past.

[Xianzhu, 2015-11-20 20:18:31]

Based on my previous experience on layout test for slimming paint, I feel this
CL is useful for full test-coverage of flags under development. We can get full
test coverage of the flags on try-bots or dedicated build-bots, not affecting
other developers and buildbots.

[skobes, 2015-11-24 19:28:35]

Feedback on blink-dev has been positive
(https://groups.google.com/a/chromium.org/d/msg/blink-dev/iy9MHeFypq0/Aujut2UB...).
 Is this ready to land?

[Dirk Pranke, 2015-11-24 21:11:36]

If you can wait another half day or day for this, I'd like to take a look
and I haven't had time yet.

-- Dirk

On Tue, Nov 24, 2015 at 11:28 AM, <skobes@chromium.org> wrote:

> Feedback on blink-dev has been positive
> (
>
https://groups.google.com/a/chromium.org/d/msg/blink-dev/iy9MHeFypq0/Aujut2UB...
> ).
>  Is this ready to land?
>
> https://codereview.chromium.org/1469433002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2015-11-24 21:11:36]

If you can wait another half day or day for this, I'd like to take a look
and I haven't had time yet.

-- Dirk

On Tue, Nov 24, 2015 at 11:28 AM, <skobes@chromium.org> wrote:

> Feedback on blink-dev has been positive
> (
>
https://groups.google.com/a/chromium.org/d/msg/blink-dev/iy9MHeFypq0/Aujut2UB...
> ).
>  Is this ready to land?
>
> https://codereview.chromium.org/1469433002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2015-11-25 03:29:59]

On 2015/11/24 21:11:36, Dirk Pranke wrote:
> If you can wait another half day or day for this, I'd like to take a look
> and I haven't had time yet.

Sorry for the delay. I conceptually like the idea and the implementation
is simple. 

lgtm.

I do have some concerns about additional work we might want to do to
make this useful on the bots (as noted in the blink-dev thread), but I wouldn't
want to block landing this on that.

[ojan, 2015-11-25 04:19:05]

ojan@chromium.org changed reviewers:
+ dpranke@chromium.org

[ojan, 2015-11-25 04:19:05]

The CQ bit was checked by ojan@chromium.org

[ojan, 2015-11-25 04:19:05]

lgtm

[commit-bot: I haz the power, 2015-11-25 04:19:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469433002/20001

[commit-bot: I haz the power, 2015-11-25 05:35:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-25 05:37:42]

Patchset 2 (id:??) landed as
https://crrev.com/44e1d1f35b8402ffaf4e7bf3e0ef9c29b196c763
Cr-Commit-Position: refs/heads/master@{#361584}