CC Animations: Fix LayerTreeHostTimelinesTestSetPotentiallyAnimatingOnLacDestruction flakiness.

CC Animations: Fix  LayerTreeHostTimelinesTestSetPotentiallyAnimatingOnLacDestruction flakiness.

Check active tree state separately, on each PrepareToDrawOnThread.

The source of the flakiness that the
test previously made assumptions about the timing of draws (when the active
tree's draw properties get updated) vs commits.

BUG=546867
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5beeedbce43c420ff95d5eee61564331e95ee5ae
Cr-Commit-Position: refs/heads/master@{#361237}

[loyso (OOO), 2015-11-23 06:39:08]

loyso@chromium.org changed reviewers:
+ ajuma@chromium.org, danakj@chromium.org

[loyso (OOO), 2015-11-23 06:39:08]

ajuma@chromium.org: Please review changes in 

danakj@chromium.org: Please review changes in

[loyso (OOO), 2015-11-23 06:41:20]

Description was changed from

==========
CC Animations: Fix 
LayerTreeHostTimelinesTestSetPotentiallyAnimatingOnLacDestruction flakiness.

Check active tree state on separately, on each PrepareToDrawOnThread.

BUG=546867
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animations: Fix 
LayerTreeHostTimelinesTestSetPotentiallyAnimatingOnLacDestruction flakiness.

Check active tree state separately, on each PrepareToDrawOnThread.

BUG=546867
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ajuma, 2015-11-23 14:25:28]

lgtm with a nit

Also, just to make sure I understand, was the source of the flakiness that the
test previously made assumptions about the timing of draws (when the active
tree's draw properties get updated) vs commits (when the test was performing
checks)?

https://codereview.chromium.org/1472723002/diff/1/cc/trees/layer_tree_host_un...
File cc/trees/layer_tree_host_unittest_animation_timelines.cc (right):

https://codereview.chromium.org/1472723002/diff/1/cc/trees/layer_tree_host_un...
cc/trees/layer_tree_host_unittest_animation_timelines.cc:1043: if
(!host_impl->active_tree())
Is this needed? (That is, does PrepareToDrawOnThread ever get called when there
isn't an active tree?)

[loyso (OOO), 2015-11-24 00:00:06]

Description was changed from

==========
CC Animations: Fix 
LayerTreeHostTimelinesTestSetPotentiallyAnimatingOnLacDestruction flakiness.

Check active tree state separately, on each PrepareToDrawOnThread.

BUG=546867
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animations: Fix 
LayerTreeHostTimelinesTestSetPotentiallyAnimatingOnLacDestruction flakiness.

Check active tree state separately, on each PrepareToDrawOnThread.

The source of the flakiness that the
test previously made assumptions about the timing of draws (when the active
tree's draw properties get updated) vs commits.

BUG=546867
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2015-11-24 00:04:15]

On 2015/11/23 14:25:28, ajuma wrote:
> Also, just to make sure I understand, was the source of the flakiness that the
> test previously made assumptions about the timing of draws (when the active
> tree's draw properties get updated) vs commits (when the test was performing
> checks)?
Yes, exactly. commits and draws are completely async/unrelated. Updated the
description.

[loyso (OOO), 2015-11-24 00:04:25]

https://codereview.chromium.org/1472723002/diff/1/cc/trees/layer_tree_host_un...
File cc/trees/layer_tree_host_unittest_animation_timelines.cc (right):

https://codereview.chromium.org/1472723002/diff/1/cc/trees/layer_tree_host_un...
cc/trees/layer_tree_host_unittest_animation_timelines.cc:1043: if
(!host_impl->active_tree())
On 2015/11/23 14:25:28, ajuma wrote:
> Is this needed? (That is, does PrepareToDrawOnThread ever get called when
there
> isn't an active tree?)

Done.

[loyso (OOO), 2015-11-24 01:23:47]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2015-11-24 01:23:47]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1472723002/#ps20001
(title: "Fix the nit.")

[commit-bot: I haz the power, 2015-11-24 01:27:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472723002/20001

[commit-bot: I haz the power, 2015-11-24 02:39:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-24 02:40:52]

Patchset 2 (id:??) landed as
https://crrev.com/5beeedbce43c420ff95d5eee61564331e95ee5ae
Cr-Commit-Position: refs/heads/master@{#361237}