Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1491543002: AudioPlayer: Update layout to show the volume slider without using popup. (Closed)

Created:
5 years ago by fukino
Modified:
5 years ago
Reviewers:
mtomasz, yawano
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AudioPlayer: Update layout to show the volume slider without using popup. Following the new visual spec, volume-related UI components are updated as follows: - Volume slider is always shown on the right-bottom corner. It used to be shown as pop-up. - Clicking volume button toggles mute status, rather than opening volume slider. - minimum width is expanded to fit time slider and volume slider in a line. BUG=488229, 554448 TEST=manually Committed: https://crrev.com/0af1af78c3d0777a9e697198ff4747e31544ab4c Cr-Commit-Position: refs/heads/master@{#362900}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -327 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_volume_muted.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_volume_muted.png View Binary file 0 comments Download
M ui/file_manager/audio_player/elements/audio_player.js View 1 chunk +0 lines, -16 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.css View 6 chunks +25 lines, -29 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.html View 1 3 chunks +10 lines, -20 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.js View 1 6 chunks +41 lines, -50 lines 0 comments Download
D ui/file_manager/audio_player/elements/volume_controller.css View 1 1 chunk +0 lines, -52 lines 0 comments Download
D ui/file_manager/audio_player/elements/volume_controller.html View 1 1 chunk +0 lines, -23 lines 0 comments Download
D ui/file_manager/audio_player/elements/volume_controller.js View 1 1 chunk +0 lines, -124 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/file_manager/audio_player/js/background.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/audio_player/js/compiled_resources.gyp View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
fukino
Could you take a look? Thanks!
5 years ago (2015-12-01 07:10:10 UTC) #3
yawano
https://codereview.chromium.org/1491543002/diff/1/ui/file_manager/audio_player/elements/control_panel.html File ui/file_manager/audio_player/elements/control_panel.html (left): https://codereview.chromium.org/1491543002/diff/1/ui/file_manager/audio_player/elements/control_panel.html#oldcode56 ui/file_manager/audio_player/elements/control_panel.html:56: <volume-controller id="volumeSlider" value="{{volume}}" If volume-controller is no longer used, ...
5 years ago (2015-12-01 07:51:31 UTC) #4
fukino
Thank you for the review! https://codereview.chromium.org/1491543002/diff/1/ui/file_manager/audio_player/elements/control_panel.html File ui/file_manager/audio_player/elements/control_panel.html (left): https://codereview.chromium.org/1491543002/diff/1/ui/file_manager/audio_player/elements/control_panel.html#oldcode56 ui/file_manager/audio_player/elements/control_panel.html:56: <volume-controller id="volumeSlider" value="{{volume}}" On ...
5 years ago (2015-12-02 04:52:03 UTC) #5
yawano
lgtm. Thank you! https://codereview.chromium.org/1491543002/diff/1/ui/file_manager/audio_player/elements/control_panel.js File ui/file_manager/audio_player/elements/control_panel.js (right): https://codereview.chromium.org/1491543002/diff/1/ui/file_manager/audio_player/elements/control_panel.js#newcode217 ui/file_manager/audio_player/elements/control_panel.js:217: this.$.volumeButton.setAttribute('aria-label', On 2015/12/02 04:52:02, fukino wrote: ...
5 years ago (2015-12-02 06:11:43 UTC) #6
fukino
On 2015/12/02 06:11:43, yawano wrote: > lgtm. Thank you! > > https://codereview.chromium.org/1491543002/diff/1/ui/file_manager/audio_player/elements/control_panel.js > File ui/file_manager/audio_player/elements/control_panel.js ...
5 years ago (2015-12-02 06:14:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491543002/20001
5 years ago (2015-12-02 06:14:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/123949)
5 years ago (2015-12-02 06:25:17 UTC) #11
fukino
Tomasz, could you take a look at chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc?
5 years ago (2015-12-03 02:24:57 UTC) #13
mtomasz
lgtm. I think you should add yourself to OWNERS in chrome/browser/chromeos/extensions/file_manager/.
5 years ago (2015-12-03 03:58:40 UTC) #14
fukino
On 2015/12/03 03:58:40, mtomasz wrote: > lgtm. > > I think you should add yourself ...
5 years ago (2015-12-03 04:05:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491543002/20001
5 years ago (2015-12-03 04:06:04 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 04:11:35 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-03 04:12:30 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0af1af78c3d0777a9e697198ff4747e31544ab4c
Cr-Commit-Position: refs/heads/master@{#362900}

Powered by Google App Engine
This is Rietveld 408576698