AudioPlayer: Stop using Object.observe() and Array.observe().

AudioPlayer: Stop using Object.observe() and Array.observe().

Object.observe() and Array.observe() will soon be deprecated.
This CL modify audio player to stop using it by listen to AudioPlayerElement's
property changes directly, rather than the model object.

BUG=552113
TEST=manually

Committed: https://crrev.com/4f121b1dcf06666a6531e2620794662fc7875e00
Cr-Commit-Position: refs/heads/master@{#363425}

[fukino, 2015-12-03 12:16:18]

fukino@chromium.org changed reviewers:
+ yoshiki@chromium.org

[fukino, 2015-12-03 12:16:18]

Yoshiki-san, PTAL this CL. Thanks!

[fukino, 2015-12-07 05:13:56]

On 2015/12/03 12:16:18, fukino wrote:
> Yoshiki-san, PTAL this CL. Thanks!

Ping. (just in case)

[yoshiki, 2015-12-07 05:39:21]

Also, please ensure that all functionality works well, since it may change the
timing of data update and may break something.

https://codereview.chromium.org/1495873002/diff/1/ui/file_manager/audio_playe...
File ui/file_manager/audio_player/js/audio_player.js (right):

https://codereview.chromium.org/1495873002/diff/1/ui/file_manager/audio_playe...
ui/file_manager/audio_player/js/audio_player.js:51:
this.player_.addEventListener(
Is it guaranteed that all requested items are returned ? If not please use
KEYS_TO_SAVE_STATES instead of the results to add handlers.

https://codereview.chromium.org/1495873002/diff/1/ui/file_manager/externs/es7...
File ui/file_manager/externs/es7_workaround.js (right):

https://codereview.chromium.org/1495873002/diff/1/ui/file_manager/externs/es7...
ui/file_manager/externs/es7_workaround.js:16: Array.observe = function(arr,
callback) {};
Could you remove them as well?

[fukino, 2015-12-07 07:21:01]

Thank you for the review! Could you take another look?

As far as I have tested, using polymer's synchronous change events instead of
Object.observe didn't break anything.

https://codereview.chromium.org/1495873002/diff/1/ui/file_manager/audio_playe...
File ui/file_manager/audio_player/js/audio_player.js (right):

https://codereview.chromium.org/1495873002/diff/1/ui/file_manager/audio_playe...
ui/file_manager/audio_player/js/audio_player.js:51:
this.player_.addEventListener(
On 2015/12/07 05:39:21, yoshiki wrote:
> Is it guaranteed that all requested items are returned ? If not please use
> KEYS_TO_SAVE_STATES instead of the results to add handlers.

Oops, thank you for pointing this out!
I had all keys in local storage and I didn't noticed this issue.
Done.

https://codereview.chromium.org/1495873002/diff/1/ui/file_manager/externs/es7...
File ui/file_manager/externs/es7_workaround.js (right):

https://codereview.chromium.org/1495873002/diff/1/ui/file_manager/externs/es7...
ui/file_manager/externs/es7_workaround.js:16: Array.observe = function(arr,
callback) {};
On 2015/12/07 05:39:21, yoshiki wrote:
> Could you remove them as well?

Done.

I think we can simple stop listening to the internal modification of tracks
property.
Whenever the audio player changes the track list, the object for the track
property is replaced, not modified.
https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/au...

So, I think we don't need to listen to the modification of the tracks object,
and simply remove Array.observe().

[fukino, 2015-12-07 07:39:44]

Description was changed from

==========
AudioPlayer: Stop using Object.observe().

Object.observe() will soon be deprecated.
This CL modify audio player to stop using it by listen to AudioPlayerElement's
property changes directly, rather than the model object.

BUG=552113
TEST=manually
==========

to

==========
AudioPlayer: Stop using Object.observe() and Array.observe().

Object.observe() and Array.observe() will soon be deprecated.
This CL modify audio player to stop using it by listen to AudioPlayerElement's
property changes directly, rather than the model object.

BUG=552113
TEST=manually
==========

[yoshiki, 2015-12-07 08:05:51]

lgtm

[fukino, 2015-12-07 08:16:31]

On 2015/12/07 08:05:51, yoshiki wrote:
> lgtm

Thank you!

[fukino, 2015-12-07 08:16:38]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2015-12-07 08:17:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1495873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1495873002/20001

[commit-bot: I haz the power, 2015-12-07 08:47:05]

Description was changed from

==========
AudioPlayer: Stop using Object.observe() and Array.observe().

Object.observe() and Array.observe() will soon be deprecated.
This CL modify audio player to stop using it by listen to AudioPlayerElement's
property changes directly, rather than the model object.

BUG=552113
TEST=manually
==========

to

==========
AudioPlayer: Stop using Object.observe() and Array.observe().

Object.observe() and Array.observe() will soon be deprecated.
This CL modify audio player to stop using it by listen to AudioPlayerElement's
property changes directly, rather than the model object.

BUG=552113
TEST=manually
==========

[commit-bot: I haz the power, 2015-12-07 08:47:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-07 08:48:05]

Description was changed from

==========
AudioPlayer: Stop using Object.observe() and Array.observe().

Object.observe() and Array.observe() will soon be deprecated.
This CL modify audio player to stop using it by listen to AudioPlayerElement's
property changes directly, rather than the model object.

BUG=552113
TEST=manually
==========

to

==========
AudioPlayer: Stop using Object.observe() and Array.observe().

Object.observe() and Array.observe() will soon be deprecated.
This CL modify audio player to stop using it by listen to AudioPlayerElement's
property changes directly, rather than the model object.

BUG=552113
TEST=manually

Committed: https://crrev.com/4f121b1dcf06666a6531e2620794662fc7875e00
Cr-Commit-Position: refs/heads/master@{#363425}
==========

[commit-bot: I haz the power, 2015-12-07 08:48:06]

Patchset 2 (id:??) landed as
https://crrev.com/4f121b1dcf06666a6531e2620794662fc7875e00
Cr-Commit-Position: refs/heads/master@{#363425}