Issue 150283005: Revert 249234 "Use MessagePumpDispatcher instead of MessageFilter"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150283005: Revert 249234 "Use MessagePumpDispatcher instead of MessageFilter" (Closed)

Created:
6 years, 10 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 10 months ago

Reviewers:
yukawa

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 249234 "Use MessagePumpDispatcher instead of MessageFilter" Failed non-Aura build. > Use MessagePumpDispatcher instead of MessageFilter > > This is a preparation to remove base::MessageLoopForUI::MessageFilter. > > BUG=330735, 319122 > TEST=done by manually executing cloud_print_service_config.exe > > Review URL: https://codereview.chromium.org/152033005 TBR=yukawa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249268

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -16 lines)			Patch
	M	trunk/src/cloud_print/service/win/cloud_print_service_config.cc	View		3 chunks	+11 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

Committed patchset #1 manually as r249268 (tree was closed).

6 years, 10 months ago (2014-02-06 04:11:53 UTC) #2

yukawa

LGTM. Thank you for handling the breakage. I haven't noticed there remain non-Aura builders for ...

6 years, 10 months ago (2014-02-06 05:17:41 UTC) #3

yukawa

6 years, 10 months ago (2014-02-07 03:06:19 UTC) #4

Message was sent while issue was closed.

On 2014/02/06 05:17:41, yukawa wrote:
> LGTM.
> Thank you for handling the breakage.  I haven't noticed there remain non-Aura
> builders for Windows.

For the record, it turned out that the build failure was a conflict with
r249105, which coincidentally removed base::RunLoop::set_dispatcher().

Expand Messages | Collapse Messages