Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1507093003: mastermon: report step metrics (Closed)

Created:
5 years ago by Paweł Hajdan Jr.
Modified:
5 years ago
Reviewers:
Adrian Kuegel
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M infra/services/mastermon/pollers.py View 2 chunks +16 lines, -0 lines 0 comments Download
M infra/services/mastermon/test/pollers_test.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Paweł Hajdan Jr.
5 years ago (2015-12-08 12:56:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507093003/1
5 years ago (2015-12-08 12:56:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-08 13:00:22 UTC) #6
Adrian Kuegel
Ok, now I understand how this is going to work :) LGTM
5 years ago (2015-12-08 13:01:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507093003/1
5 years ago (2015-12-08 13:29:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/6dc91d3b47be362037abaa0ba00a71a527cd67d9
5 years ago (2015-12-08 13:34:47 UTC) #11
Paweł Hajdan Jr.
5 years ago (2015-12-11 12:43:36 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1515073003/ by phajdan.jr@chromium.org.

The reason for reverting is: Strongly suspected to cause mastermon alerts.
https://codereview.chromium.org/1513183005 didn't seem to help.

See https://goto.google.com/wudvc (Google-internal) for more context..

Powered by Google App Engine
This is Rietveld 408576698