Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 158463003: Remove WM_DEADCHAR/WM_SYSDEADCHAR handler (Closed)

Created:
6 years, 10 months ago by yukawa
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove WM_DEADCHAR/WM_SYSDEADCHAR handler The idea to handle WM_DEADCHAR/WM_SYSDEADCHAR as an IME composition was finally abandoned as r230342. We can now safely remove those handlers. BUG=330735, 319122 TEST=manually done with US-international keyboard on Win 7 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M ui/base/ime/input_method_imm32.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/base/ime/input_method_win.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/ime/input_method_win.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/views/win/hwnd_message_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yukawa
Hi Scott, Could you take a look at this CL? I made sure that it's ...
6 years, 10 months ago (2014-02-10 13:54:54 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-02-10 15:59:44 UTC) #2
yukawa
The CQ bit was checked by yukawa@chromium.org
6 years, 10 months ago (2014-02-11 14:43:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/158463003/1
6 years, 10 months ago (2014-02-11 14:43:30 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 17:03:18 UTC) #5
Message was sent while issue was closed.
Change committed as 250432

Powered by Google App Engine
This is Rietveld 408576698