Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1604423002: Let SetEnv.cmd set VSINSTALLDIR, VCINSTALLDIR (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
scottmg, brucedawson
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Let SetEnv.cmd set VSINSTALLDIR, VCINSTALLDIR We use depot_tools's toolchain to build LLVM on the clang/win bots. llvm-symbolizer relies on VSINSTALLDIR to be set to find the DIA SDK, so set it. While here, also set VCINSTALLDIR. BUG=82385 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298326

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M win_toolchain/package_from_installed.py View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
Nico
If this goes in, how long does it take to make it into the deployed ...
4 years, 11 months ago (2016-01-20 20:46:25 UTC) #2
scottmg
lgtm If you can convince Bruce to repackage 2015, this could be in the 2015 ...
4 years, 11 months ago (2016-01-20 20:50:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604423002/1
4 years, 11 months ago (2016-01-20 20:51:14 UTC) #6
Nico
On 2016/01/20 20:50:24, scottmg wrote: > lgtm > > If you can convince Bruce to ...
4 years, 11 months ago (2016-01-20 20:52:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298326
4 years, 11 months ago (2016-01-20 20:53:02 UTC) #9
brucedawson
4 years, 11 months ago (2016-01-20 20:58:30 UTC) #11
Message was sent while issue was closed.
On 2016/01/20 20:52:24, Nico wrote:
> On 2016/01/20 20:50:24, scottmg wrote:
> > lgtm
> > 
> > If you can convince Bruce to repackage 2015, this could be in the 2015
rollout
> > which should be "real soon".
> 
> That should be no problem, I took a rhetoric class recently! Watch this:
> 
> bruuuuuuuuuuuuuce
> pleeeeeeaaaaaaase
> 
> pleeeeeeeeeeaaaaaaaaaaaase

You will remove these restraints and leave this cell with the door open.

Yeah, I should be able to do that. I've got the VMs setup for packaging VS.

Powered by Google App Engine
This is Rietveld 408576698