allocator cleanup: remove memory benchmarking extension

allocator cleanup: remove memory benchmarking extension

The memory benchmarking extension, introduced in crrev.com/12211008
allows to expose the TCMalloc heap profiler methods to JS by passing
a command line flag.
These days there doesn't seem to be any client left anywhere in the
codebase. See also the thread:
[chromium-dev] Is anybody using/caring about --enable-memory-benchmarking

The command line switch itself is deliberately not removed as it
still relied on for crbug.com/513692

BUG=564618
Committed: https://crrev.com/bdcad645c59f39bb4ccb72f04ebdd0ab1e2bf75d
Cr-Commit-Position: refs/heads/master@{#371285}

[Primiano Tucci (use gerrit), 2016-01-20 18:53:18]

Description was changed from

==========
allocator cleanup: remove memory benchmarking extension

The memory benchmarking extension, introduced in crrev.com/12211008
allows to expose the TCMalloc heap profiler methods to JS by passing
a command line flag.
These days there doesn't seem to be any client left anywhere in the
codebase. See also the thread:
[chromium-dev] Is anybody using/caring about --enable-memory-benchmarking

BUG=564618
==========

to

==========
allocator cleanup: remove memory benchmarking extension

The memory benchmarking extension, introduced in crrev.com/12211008
allows to expose the TCMalloc heap profiler methods to JS by passing
a command line flag.
These days there doesn't seem to be any client left anywhere in the
codebase. See also the thread:
[chromium-dev] Is anybody using/caring about --enable-memory-benchmarking

The command line switch itself is deliberately not removed as it
still relied on for crbug.com/513692

BUG=564618
==========

[Primiano Tucci (use gerrit), 2016-01-20 18:59:13]

primiano@chromium.org changed reviewers:
+ piman@chromium.org

[Primiano Tucci (use gerrit), 2016-01-20 18:59:13]

piman, mind a fully negative (in diff sense) cleanup CL?

Just to be clear, this is removing only the extension that exposes the dump
function to JavaScript, not any tcmalloc heap profiler ability.

sque/sonnyrao/bccheng FYI
My understanding is that this is not used anywhere not even in CrOS, please
correct me if I am wrong.

[Primiano Tucci (use gerrit), 2016-01-20 18:59:29]

primiano@chromium.org changed reviewers:
+ sonnyrao@chromium.org, sque@chromium.org

[Simon Que, 2016-01-20 20:28:47]

On 2016/01/20 18:59:29, Primiano Tucci wrote:

I don't see "--enable-memory-benchmarking" in the Chromium OS code base. It is
probably OK.

[piman, 2016-01-20 21:26:45]

lgtm

[Primiano Tucci (use gerrit), 2016-01-25 17:45:18]

primiano@chromium.org changed reviewers:
+ tsepez@chromium.org

[Primiano Tucci (use gerrit), 2016-01-25 17:45:18]

+tsepez for *messages*.h

[Tom Sepez, 2016-01-25 18:00:09]

https://codereview.chromium.org/1610213002/diff/20001/content/common/memory_b...
File content/common/memory_benchmark_messages.h (left):

https://codereview.chromium.org/1610213002/diff/20001/content/common/memory_b...
content/common/memory_benchmark_messages.h:12: #define IPC_MESSAGE_START
MemoryBenchmarkMsgStart
Is MemoryBenchmarkMsgStart now unused? If so, remove from
ipc/ipc_message_start.h

[Primiano Tucci (use gerrit), 2016-01-25 18:01:59]

https://codereview.chromium.org/1610213002/diff/20001/content/common/memory_b...
File content/common/memory_benchmark_messages.h (left):

https://codereview.chromium.org/1610213002/diff/20001/content/common/memory_b...
content/common/memory_benchmark_messages.h:12: #define IPC_MESSAGE_START
MemoryBenchmarkMsgStart
On 2016/01/25 18:00:09, Tom Sepez wrote:
> Is MemoryBenchmarkMsgStart now unused? If so, remove from
> ipc/ipc_message_start.h

Oh good point, I missed that. Done.

[Tom Sepez, 2016-01-25 18:02:13]

lgtm

[Primiano Tucci (use gerrit), 2016-01-25 18:02:41]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2016-01-25 18:02:42]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1610213002/#ps40001
(title: "Remove from ipc_message_start.h")

[commit-bot: I haz the power, 2016-01-25 18:05:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1610213002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1610213002/40001

[commit-bot: I haz the power, 2016-01-25 19:43:55]

Description was changed from

==========
allocator cleanup: remove memory benchmarking extension

The memory benchmarking extension, introduced in crrev.com/12211008
allows to expose the TCMalloc heap profiler methods to JS by passing
a command line flag.
These days there doesn't seem to be any client left anywhere in the
codebase. See also the thread:
[chromium-dev] Is anybody using/caring about --enable-memory-benchmarking

The command line switch itself is deliberately not removed as it
still relied on for crbug.com/513692

BUG=564618
==========

to

==========
allocator cleanup: remove memory benchmarking extension

The memory benchmarking extension, introduced in crrev.com/12211008
allows to expose the TCMalloc heap profiler methods to JS by passing
a command line flag.
These days there doesn't seem to be any client left anywhere in the
codebase. See also the thread:
[chromium-dev] Is anybody using/caring about --enable-memory-benchmarking

The command line switch itself is deliberately not removed as it
still relied on for crbug.com/513692

BUG=564618
==========

[commit-bot: I haz the power, 2016-01-25 19:43:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-25 19:54:05]

Description was changed from

==========
allocator cleanup: remove memory benchmarking extension

The memory benchmarking extension, introduced in crrev.com/12211008
allows to expose the TCMalloc heap profiler methods to JS by passing
a command line flag.
These days there doesn't seem to be any client left anywhere in the
codebase. See also the thread:
[chromium-dev] Is anybody using/caring about --enable-memory-benchmarking

The command line switch itself is deliberately not removed as it
still relied on for crbug.com/513692

BUG=564618
==========

to

==========
allocator cleanup: remove memory benchmarking extension

The memory benchmarking extension, introduced in crrev.com/12211008
allows to expose the TCMalloc heap profiler methods to JS by passing
a command line flag.
These days there doesn't seem to be any client left anywhere in the
codebase. See also the thread:
[chromium-dev] Is anybody using/caring about --enable-memory-benchmarking

The command line switch itself is deliberately not removed as it
still relied on for crbug.com/513692

BUG=564618

Committed: https://crrev.com/bdcad645c59f39bb4ccb72f04ebdd0ab1e2bf75d
Cr-Commit-Position: refs/heads/master@{#371285}
==========

[commit-bot: I haz the power, 2016-01-25 19:54:06]

Patchset 3 (id:??) landed as
https://crrev.com/bdcad645c59f39bb4ccb72f04ebdd0ab1e2bf75d
Cr-Commit-Position: refs/heads/master@{#371285}