Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1662523004: Delete base/prefs and update callers to use components. (Closed)

Created:
4 years, 10 months ago by brettw
Modified:
4 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, msramek+watch_chromium.org, sadrul, oshima+watch_chromium.org, droger+watchlist_chromium.org, vmpstr+watch_chromium.org, blundell+watchlist_chromium.org, Michael van Ouwerkerk, browser-components-watch_chromium.org, bondd+autofillwatch_chromium.org, noyau+watch_chromium.org, markusheintz_, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, zea+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, grt+watch_chromium.org, lcwu+watch_chromium.org, sdefresne+watchlist_chromium.org, raymes+watch_chromium.org, tzik, halliwell+watch_chromium.org, devtools-reviews_chromium.org, vabr+watchlistautofill_chromium.org, kalyank, android-webview-reviews_chromium.org, derat+watch_chromium.org, rouslan+autofill_chromium.org, nhiroki, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, gunsch+watch_chromium.org, sdefresne+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, plaree+watch_chromium.org, davemoore+watch_chromium.org, estade+watch_chromium.org, James Su, kinuko+fileapi, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete base/prefs and update callers to use components. Deletes the forwarding headers in base/prefs. Updates the remaining users of base/prefs includes to use components/prefs. Sort headers in updated files. Move PrefServiceFactory out of the base namespace. Update users. Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to COMPONENTS_PREFS_. Add components/prefs to DEPS file of directories where checkdeps fails after the update. BUG=583034 Committed: https://crrev.com/1f5feb7e317e3c257090858e950273b64a2e31ef Cr-Commit-Position: refs/heads/master@{#373105}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -656 lines) Patch
M android_webview/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/aw_browser_context.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/aw_metrics_service_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M android_webview/browser/aw_pref_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_autofill_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_autofill_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/chromeos/power/power_event_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
D base/prefs/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D base/prefs/base_prefs_export.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/default_pref_store.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/json_pref_store.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/mock_pref_change_callback.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/overlay_user_pref_store.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/persistent_pref_store.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_change_registrar.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_filter.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_member.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_notifier.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_notifier_impl.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_observer.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_registry.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_registry_simple.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_service.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_service_factory.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_store.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_store_observer_mock.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_value_map.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/pref_value_store.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/scoped_user_pref_update.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/testing_pref_service.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/testing_pref_store.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/value_map_pref_store.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/prefs/writeable_pref_store.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/browser/android/cast_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +1 line, -1 line 0 comments Download
M chromecast/browser/cast_browser_process.cc View 2 chunks +1 line, -1 line 0 comments Download
M chromecast/browser/devtools/remote_debugging_server.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/browser/metrics/cast_stability_metrics_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/browser/pref_service_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/pref_service_helper.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chromeos/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/audio/audio_devices_pref_handler_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/auth/login_performer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chromeos/timezone/timezone_resolver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autocomplete_history_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_experiments.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_test_utils.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_wallet_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_wallet_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/options_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/core/browser/test_autofill_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/core/browser/ui/card_unmask_prompt_controller_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/bookmarks/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_expanded_state_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/bookmarks/managed/managed_bookmarks_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/managed/managed_bookmarks_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/browser_sync/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/browser_sync/browser/profile_sync_components_factory_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/content_settings/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/content_settings/core/browser/content_settings_default_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_default_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/content_settings/core/browser/content_settings_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_pref.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_pref_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_pref_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/content_settings/core/browser/content_settings_registry_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_usages_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/cookie_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/cookie_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/host_content_settings_map.h View 2 chunks +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/host_content_settings_map.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/website_settings_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/website_settings_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/android/cronet_data_reduction_proxy.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/cronet/android/cronet_in_memory_pref_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M components/data_reduction_proxy/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_retrieval_params.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_retrieval_params_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_experiments_stats_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/dom_distiller/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/core/distilled_page_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/drive/change_list_loader_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/drive/directory_loader_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/drive/drive_test_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/drive/file_system.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/drive/file_system/operation_test_base.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/drive/file_system_core_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/drive/file_system_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/drive/job_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/job_scheduler_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/drive/sync_client_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/feedback/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/feedback/feedback_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/cpp/prefs/pref_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/cpp/prefs/pref_service_factory.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/flags_ui/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/flags_ui/flags_state_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/flags_ui/pref_service_flags_storage.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/gcm_driver/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_syncer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/gcm_driver/gcm_profile_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/google/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/google/core/browser/google_url_tracker.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/google/core/browser/google_url_tracker_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/history/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/history/core/browser/expire_history_backend_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/history/core/browser/history_backend_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/history/core/browser/top_sites_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/history/core/browser/top_sites_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/history/core/browser/typed_url_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/typed_url_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/invalidation/impl/invalidator_storage.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/impl/invalidator_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/ticl_profile_settings_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/ticl_profile_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/ticl_profile_settings_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/keyed_service/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/keyed_service/core/keyed_service_base_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/clean_exit_beacon.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/cloned_install_detector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/metrics/cloned_install_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/daily_event.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/metrics/daily_event_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/metrics_log.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/prefs/BUILD.gn View 3 chunks +1 line, -32 lines 0 comments Download
M components/prefs/base_prefs_export.h View 1 chunk +11 lines, -11 lines 0 comments Download
M components/prefs/default_pref_store.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/prefs/json_pref_store.h View 4 chunks +5 lines, -5 lines 0 comments Download
M components/prefs/mock_pref_change_callback.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/prefs/overlay_user_pref_store.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/prefs/persistent_pref_store.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/prefs/pref_change_registrar.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/prefs/pref_filter.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/prefs/pref_member.h View 8 chunks +24 lines, -22 lines 0 comments Download
M components/prefs/pref_notifier.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/prefs/pref_notifier_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/prefs/pref_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/prefs/pref_registry.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/prefs/pref_registry_simple.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/prefs/pref_service.h View 4 chunks +5 lines, -5 lines 0 comments Download
M components/prefs/pref_service_factory.h View 1 2 3 chunks +5 lines, -7 lines 0 comments Download
M components/prefs/pref_service_factory.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M components/prefs/pref_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/prefs/pref_store.h View 3 chunks +5 lines, -5 lines 0 comments Download
M components/prefs/pref_store_observer_mock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/prefs/pref_value_map.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/prefs/pref_value_store.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/prefs/prefs.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/prefs/scoped_user_pref_update.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/prefs/testing_pref_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/prefs/testing_pref_store.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/prefs/value_map_pref_store.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/prefs/writeable_pref_store.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/syncable_prefs/pref_service_syncable_factory.h View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/app_window/app_window_geometry_cache_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/extension_pref_store.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_pref_value_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_pref_value_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_prefs_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/lazy_background_task_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_prefs.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M extensions/shell/browser/shell_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/application_context_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autocomplete/shortcuts_backend_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/bookmarks/bookmark_model_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/bookmarks/bookmarks_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/browser_state_info_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/content_settings/host_content_settings_map_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/data_reduction_proxy/ios_chrome_data_reduction_proxy_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/data_reduction_proxy/ios_chrome_data_reduction_proxy_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/geolocation/omnibox_geolocation_local_state.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/geolocation/omnibox_geolocation_local_state_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/google/google_url_tracker_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/history/history_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/history/web_history_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/interstitials/ios_security_interstitial_page.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/memory/memory_debugger_manager.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/net/http_server_properties_manager_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/net/ios_chrome_http_user_agent_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/net/ios_chrome_http_user_agent_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/net/ios_chrome_network_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/passwords/credential_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/prefs/browser_prefs.mm View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/prefs/ios_chrome_pref_service_factory.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/prefs/pref_observer_bridge.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/safe_browsing/ui_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/search_engines/search_engines_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/browser_state_data_remover.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/signin_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/signin_manager_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ssl/ios_ssl_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/sync_setup_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/translate/chrome_ios_translate_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/translate/translate_accept_languages_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/flags_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/history/browsing_history_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/test/ios_chrome_scoped_testing_local_state.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/crnet/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/crnet/crnet_environment.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/crnet/sdch_owner_pref_storage.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/crnet/sdch_owner_pref_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M mash/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mash/wallpaper/wallpaper.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/chromium/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/libaddressinput/chromium/chrome_storage_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/chromium/chrome_storage_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/chromium/chrome_storage_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (14 generated)
brettw
4 years, 10 months ago (2016-02-02 18:26:37 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662523004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662523004/1
4 years, 10 months ago (2016-02-02 18:28:12 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/16274)
4 years, 10 months ago (2016-02-02 18:58:23 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662523004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662523004/20001
4 years, 10 months ago (2016-02-02 20:43:54 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/137824) linux_chromium_rel_ng on ...
4 years, 10 months ago (2016-02-02 20:56:50 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662523004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662523004/40001
4 years, 10 months ago (2016-02-02 21:25:50 UTC) #14
brettw
-> estade (jam is busy) Last base/prefs patch.
4 years, 10 months ago (2016-02-02 22:00:01 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-02 22:44:38 UTC) #18
Evan Stade
nit: BUG=583034 in description lgtm
4 years, 10 months ago (2016-02-02 23:54:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662523004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662523004/40001
4 years, 10 months ago (2016-02-03 00:31:15 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-03 00:51:53 UTC) #24
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/1f5feb7e317e3c257090858e950273b64a2e31ef Cr-Commit-Position: refs/heads/master@{#373105}
4 years, 10 months ago (2016-02-03 00:52:56 UTC) #26
msw
4 years, 10 months ago (2016-02-03 01:15:06 UTC) #27
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1662843002/ by msw@chromium.org.

The reason for reverting is: Broke Win Builder compile:
https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/19463....

Powered by Google App Engine
This is Rietveld 408576698