Make empty selection behavior behave like Android EditText.

Make empty selection behavior behave like Android EditText.

1) When long-pressing a whitespace region in text field, the Android
convention is to select zero characters and show an insertion handle (as
opposed to the current behavior of selecting some whitespace and showing
two selection handles).  One important consequence of this is that
insertion handles only show a "Paste" menu item, instead of the full
suite of Cut/Copy/etc.  I just needed to remove the unnecessary
exclusion of editable nodes on the preexisting logic.

2) When single-tapping elsewhere, Paste popups should be cleared along
with the insertion handle.  Otherwise the paste menu keeps following the cursor
around and is difficult to get rid of.  This is a preexisting bug made
much more common by change 1.

3) When the insertion handle is dragged, I noticed EditText brings back
the Paste menu, so also add a few lines of code to do that.  (Some state
was already kept to support the "tap the handle to hide Paste/tap it again
to show Paste" behavior, so I just reused that.)

BUG=582628
Committed: https://crrev.com/1f5f2cacd588280568c40faa88a6dfdfaa867976
Cr-Commit-Position: refs/heads/master@{#373606}

[aelias_OOO_until_Jul13, 2016-02-03 05:56:21]

Description was changed from

==========
Make empty selection behavior behave like Android EditText.

1) When long-pressing a whitespace region in text field, the Android
convention is to select zero characters and show an insertion handle (as
opposed to the current behavior of selecting some whitespace and showing
two selection handles).  One important consequence of this is that
insertion handles only show a "Paste" menu item, instead of the full
suite of Cut/Copy/etc.  I just needed to remove the unnecessary
exclusion of editable nodes on similar preexisting logic.

2) When single-tapping elsewhere, Paste popups should be cleared along
with the insertion handle.  Otherwise the paste menu keeps following the cursor
around and is difficult to get rid of.  This is a preexisting bug made
visible by change 1 (because in the past insertion handles almost only
showed on completely empty textboxes).

3) When the insertion handle is dragged, I noticed EditText brings back
the Paste menu, so also add some a few lines of code to do that.  (A
paste menu existence boolean was already kept to support the
"tap the handle to hide Paste/tap it again to show Paste" behavior, so I
just reused that.)

BUG=582628
==========

to

==========
Make empty selection behavior behave like Android EditText.

1) When long-pressing a whitespace region in text field, the Android
convention is to select zero characters and show an insertion handle (as
opposed to the current behavior of selecting some whitespace and showing
two selection handles).  One important consequence of this is that
insertion handles only show a "Paste" menu item, instead of the full
suite of Cut/Copy/etc.  I just needed to remove the unnecessary
exclusion of editable nodes on similar preexisting logic.

2) When single-tapping elsewhere, Paste popups should be cleared along
with the insertion handle.  Otherwise the paste menu keeps following the cursor
around and is difficult to get rid of.  This is a preexisting bug made
much more common by change 1.

3) When the insertion handle is dragged, I noticed EditText brings back
the Paste menu, so also add a few lines of code to do that.  (Some state 
was already kept to support the "tap the handle to hide Paste/tap it again
to show Paste" behavior, so I just reused that.)

BUG=582628
==========

[aelias_OOO_until_Jul13, 2016-02-03 05:56:21]

aelias@chromium.org changed reviewers:
+ tedchoc@chromium.org, yosin@chromium.org

[aelias_OOO_until_Jul13, 2016-02-03 05:57:12]

Description was changed from

==========
Make empty selection behavior behave like Android EditText.

1) When long-pressing a whitespace region in text field, the Android
convention is to select zero characters and show an insertion handle (as
opposed to the current behavior of selecting some whitespace and showing
two selection handles).  One important consequence of this is that
insertion handles only show a "Paste" menu item, instead of the full
suite of Cut/Copy/etc.  I just needed to remove the unnecessary
exclusion of editable nodes on similar preexisting logic.

2) When single-tapping elsewhere, Paste popups should be cleared along
with the insertion handle.  Otherwise the paste menu keeps following the cursor
around and is difficult to get rid of.  This is a preexisting bug made
much more common by change 1.

3) When the insertion handle is dragged, I noticed EditText brings back
the Paste menu, so also add a few lines of code to do that.  (Some state 
was already kept to support the "tap the handle to hide Paste/tap it again
to show Paste" behavior, so I just reused that.)

BUG=582628
==========

to

==========
Make empty selection behavior behave like Android EditText.

1) When long-pressing a whitespace region in text field, the Android
convention is to select zero characters and show an insertion handle (as
opposed to the current behavior of selecting some whitespace and showing
two selection handles).  One important consequence of this is that
insertion handles only show a "Paste" menu item, instead of the full
suite of Cut/Copy/etc.  I just needed to remove the unnecessary
exclusion of editable nodes on the preexisting logic.

2) When single-tapping elsewhere, Paste popups should be cleared along
with the insertion handle.  Otherwise the paste menu keeps following the cursor
around and is difficult to get rid of.  This is a preexisting bug made
much more common by change 1.

3) When the insertion handle is dragged, I noticed EditText brings back
the Paste menu, so also add a few lines of code to do that.  (Some state 
was already kept to support the "tap the handle to hide Paste/tap it again
to show Paste" behavior, so I just reused that.)

BUG=582628
==========

[aelias_OOO_until_Jul13, 2016-02-03 05:57:51]

PTAL,

yosin@ for core/editing
tedchoc@ for ContentViewCore.java

[yosin_UTC9, 2016-02-03 06:49:28]

lgtm for core/editing

https://codereview.chromium.org/1668453002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/SelectionController.cpp (right):

https://codereview.chromium.org/1668453002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/SelectionController.cpp:310: String str =
plainText(range, TextIteratorDefaultBehavior);
nit: |const String&| to avoid unnecessary copy of |String|

[aelias_OOO_until_Jul13, 2016-02-04 03:58:56]

Done, just need ContentViewCore review.

[Ted C, 2016-02-04 18:48:50]

lgtm

[aelias_OOO_until_Jul13, 2016-02-04 19:11:53]

The CQ bit was checked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2016-02-04 19:11:54]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1668453002/#ps40001
(title: "Apply code review and fix test")

[commit-bot: I haz the power, 2016-02-04 19:13:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1668453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1668453002/40001

[commit-bot: I haz the power, 2016-02-04 20:30:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-04 20:31:38]

Description was changed from

==========
Make empty selection behavior behave like Android EditText.

1) When long-pressing a whitespace region in text field, the Android
convention is to select zero characters and show an insertion handle (as
opposed to the current behavior of selecting some whitespace and showing
two selection handles).  One important consequence of this is that
insertion handles only show a "Paste" menu item, instead of the full
suite of Cut/Copy/etc.  I just needed to remove the unnecessary
exclusion of editable nodes on the preexisting logic.

2) When single-tapping elsewhere, Paste popups should be cleared along
with the insertion handle.  Otherwise the paste menu keeps following the cursor
around and is difficult to get rid of.  This is a preexisting bug made
much more common by change 1.

3) When the insertion handle is dragged, I noticed EditText brings back
the Paste menu, so also add a few lines of code to do that.  (Some state 
was already kept to support the "tap the handle to hide Paste/tap it again
to show Paste" behavior, so I just reused that.)

BUG=582628
==========

to

==========
Make empty selection behavior behave like Android EditText.

1) When long-pressing a whitespace region in text field, the Android
convention is to select zero characters and show an insertion handle (as
opposed to the current behavior of selecting some whitespace and showing
two selection handles).  One important consequence of this is that
insertion handles only show a "Paste" menu item, instead of the full
suite of Cut/Copy/etc.  I just needed to remove the unnecessary
exclusion of editable nodes on the preexisting logic.

2) When single-tapping elsewhere, Paste popups should be cleared along
with the insertion handle.  Otherwise the paste menu keeps following the cursor
around and is difficult to get rid of.  This is a preexisting bug made
much more common by change 1.

3) When the insertion handle is dragged, I noticed EditText brings back
the Paste menu, so also add a few lines of code to do that.  (Some state
was already kept to support the "tap the handle to hide Paste/tap it again
to show Paste" behavior, so I just reused that.)

BUG=582628

Committed: https://crrev.com/1f5f2cacd588280568c40faa88a6dfdfaa867976
Cr-Commit-Position: refs/heads/master@{#373606}
==========

[commit-bot: I haz the power, 2016-02-04 20:31:39]

Patchset 3 (id:??) landed as
https://crrev.com/1f5f2cacd588280568c40faa88a6dfdfaa867976
Cr-Commit-Position: refs/heads/master@{#373606}