android envsetup: Stop setting GYP_DEFINES.

android envsetup: Stop setting GYP_DEFINES.

After this, envsetup no longer sets OS=android and no longer translates
GOMADIR to use_goma=1. You now need to set these yourself, but since
envsetup no longer overwrites GYP_DEFINES, setting them is now much
easier. (For example, just run
`export GYP_DEFINES='OS=android use_goma=1'` before running
`gclient sync`).

BUG=330631
R=yfriedman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260548

[Nico, 2014-03-27 18:58:22]

I suppose I need an lgtm for this if I want to land this on monday :-)

[Yaron, 2014-03-27 19:08:06]

On 2014/03/27 18:58:22, Nico wrote:
> I suppose I need an lgtm for this if I want to land this on monday :-)

lgtm

[Nico, 2014-03-31 15:12:50]

Committed patchset #3 manually as r260548 (tree was closed).

[Miguel Garcia, 2014-03-31 16:39:14]

On 2014/03/31 15:12:50, Nico wrote:
> Committed patchset #3 manually as r260548 (tree was closed).

While I agree that envsetup had grew into an enormous monster, this was actually
useful. How are we going to remember to set these two gyp defines every time we
open a new shell? This is the kind of thing we would script and share which is
precisely what envesetup was doing...

[Nico, 2014-03-31 16:50:16]

On 2014/03/31 16:39:14, Miguel Garcia wrote:
> On 2014/03/31 15:12:50, Nico wrote:
> > Committed patchset #3 manually as r260548 (tree was closed).
> 
> While I agree that envsetup had grew into an enormous monster, this was
actually
> useful. How are we going to remember to set these two gyp defines every time
we
> open a new shell? This is the kind of thing we would script and share which is
> precisely what envesetup was doing...

See this thread:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/_lULw0aZhkk

I updated all build instruction pages I could find with the new steps.