Only show Reader Mode infobar on long articles

Only show Reader Mode infobar on long articles

Add a new model to predict whether a distillable page is long enough,
and stop prompting the Reader Mode infobar if not.

BUG=587974
Committed: https://crrev.com/e9ef74ab7411ca08359015167b2c2bc1b566f95b
Cr-Commit-Position: refs/heads/master@{#376294}

[wychen, 2016-02-18 04:48:32]

Patchset #1 (id:1) has been deleted

[wychen, 2016-02-18 04:49:09]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 04:49:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703313003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703313003/20001

[wychen, 2016-02-18 04:50:35]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2016-02-18 04:50:35]

PTAL

[commit-bot: I haz the power, 2016-02-18 06:18:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 06:18:28]

Dry run: This issue passed the CQ dry run.

[mdjones, 2016-02-18 17:17:21]

lgtm

https://codereview.chromium.org/1703313003/diff/20001/components/dom_distille...
File components/dom_distiller/content/renderer/distillability_agent.cc (right):

https://codereview.chromium.org/1703313003/diff/20001/components/dom_distille...
components/dom_distiller/content/renderer/distillability_agent.cc:55: const
DistillablePageDetector* long_page,
If we add any more of these, we can probably just pass an array of page
detectors.

[wychen, 2016-02-18 21:45:13]

Description was changed from

==========
Only show Reader Mode infobar on long articles

Add a new model to predict whether a distillable page is long enough,
and stop prompting the Reader Mode infobar if not.

BUG=
==========

to

==========
Only show Reader Mode infobar on long articles

Add a new model to predict whether a distillable page is long enough,
and stop prompting the Reader Mode infobar if not.

BUG=587974
==========

[wychen, 2016-02-18 21:47:23]

https://codereview.chromium.org/1703313003/diff/20001/components/dom_distille...
File components/dom_distiller/content/renderer/distillability_agent.cc (right):

https://codereview.chromium.org/1703313003/diff/20001/components/dom_distille...
components/dom_distiller/content/renderer/distillability_agent.cc:55: const
DistillablePageDetector* long_page,
On 2016/02/18 17:17:21, mdjones wrote:
> If we add any more of these, we can probably just pass an array of page
> detectors.

Acknowledged. It's hard to say whether we need more, or how
it would be used. If it's not ANDed together, having named
variable for each one is easier to understand.

[wychen, 2016-02-18 22:47:16]

The CQ bit was checked by wychen@chromium.org

[wychen, 2016-02-18 22:47:16]

The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org
Link to the patchset: https://codereview.chromium.org/1703313003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-02-18 22:51:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703313003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703313003/40001

[commit-bot: I haz the power, 2016-02-19 00:18:49]

Description was changed from

==========
Only show Reader Mode infobar on long articles

Add a new model to predict whether a distillable page is long enough,
and stop prompting the Reader Mode infobar if not.

BUG=587974
==========

to

==========
Only show Reader Mode infobar on long articles

Add a new model to predict whether a distillable page is long enough,
and stop prompting the Reader Mode infobar if not.

BUG=587974
==========

[commit-bot: I haz the power, 2016-02-19 00:18:50]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-02-19 00:19:55]

Description was changed from

==========
Only show Reader Mode infobar on long articles

Add a new model to predict whether a distillable page is long enough,
and stop prompting the Reader Mode infobar if not.

BUG=587974
==========

to

==========
Only show Reader Mode infobar on long articles

Add a new model to predict whether a distillable page is long enough,
and stop prompting the Reader Mode infobar if not.

BUG=587974

Committed: https://crrev.com/e9ef74ab7411ca08359015167b2c2bc1b566f95b
Cr-Commit-Position: refs/heads/master@{#376294}
==========

[commit-bot: I haz the power, 2016-02-19 00:19:56]

Patchset 2 (id:??) landed as
https://crrev.com/e9ef74ab7411ca08359015167b2c2bc1b566f95b
Cr-Commit-Position: refs/heads/master@{#376294}