Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1756763002: 2016-03-02T18:53:01 LayoutPosition

Created:
4 years, 9 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

2016-03-02T18:53:01 Design Doc (WIP): https://docs.google.com/document/d/1IXgwcToTLxy-mrtzBlhEz-liURaqCM76yNd10ciCgZ0/edit?usp=sharing BUG=587723 BUG=612416 Text cursor can't advance past LEFT-TO-RIGHT OVERRIDE character

Patch Set 1 : 2016-03-02T18:53:01 #

Patch Set 2 : 2016-03-03T19:05:52 #

Patch Set 3 : 2016-03-04T13:14:20 BiDi tests #

Patch Set 4 : 2016-03-04T17:14:39 #

Patch Set 5 : 2016-03-07T16:08:21 #

Patch Set 6 : 2016-03-07T18:39:28 #

Patch Set 7 : 2016-03-08T13:46:43 #

Patch Set 8 : 2016-03-08T14:52:05 #

Patch Set 9 : 2016-03-08T16:09:33 #

Patch Set 10 : 2016-03-08T17:15:13 #

Patch Set 11 : 2016-03-08T18:25:44 #

Patch Set 12 : 2016-03-10T18:59:51 #

Patch Set 13 : 2016-03-11T19:01:49 #

Patch Set 14 : 2016-03-14T14:23:04 #

Patch Set 15 : 2016-03-14T17:57:46 #

Patch Set 16 : 2016-03-31T14:58:57 #

Patch Set 17 : 2016-03-31T17:10:31 #

Patch Set 18 : 2016-04-01T09:47:34 #

Patch Set 19 : 2016-04-05T18:59:09 #

Patch Set 20 : 2016-04-06T18:57:47 #

Patch Set 21 : 2016-04-07T19:25:35 #

Patch Set 22 : 2016-04-11T18:49:39 #

Patch Set 23 : 2016-04-12T18:43:19 #

Patch Set 24 : 2016-04-14T10:00:38 #

Patch Set 25 : 2016-04-14T18:13:31 #

Patch Set 26 : 2016-04-19T19:02:33 #

Patch Set 27 : 2016-04-25T19:02:18 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2567 lines, -539 lines) Patch
M components/test_runner/text_input_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/image-before-linebreak.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/LayoutPosition.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +147 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/LayoutPosition.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +799 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/LayoutPositionTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +307 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/LayoutTreePrinter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/LayoutTreePrinter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +395 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/LayoutTreeTraversal.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/LayoutTreeTraversal.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +63 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 7 chunks +59 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +57 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionWithAffinity.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 6 chunks +39 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 19 chunks +399 lines, -372 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 23 chunks +139 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutItem.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
yosin_UTC9
Description was changed from ========== 2016-03-02T18:53:01 BUG= ========== to ========== 2016-03-02T18:53:01 BUG=587723 ==========
4 years, 9 months ago (2016-03-09 01:40:39 UTC) #1
yosin_UTC9
Description was changed from ========== 2016-03-02T18:53:01 BUG=587723 ========== to ========== 2016-03-02T18:53:01 BUG=587723 BUG=612416 Text cursor ...
4 years, 7 months ago (2016-05-23 04:44:45 UTC) #2
yosin_UTC9
4 years, 3 months ago (2016-08-26 01:51:24 UTC) #3 
Description was changed from

==========
2016-03-02T18:53:01

BUG=587723

BUG=612416 Text cursor can't advance past LEFT-TO-RIGHT OVERRIDE character
==========

to

==========
2016-03-02T18:53:01

Design Doc (WIP):
https://docs.google.com/document/d/1IXgwcToTLxy-mrtzBlhEz-liURaqCM76yNd10ciCg...

BUG=587723

BUG=612416 Text cursor can't advance past LEFT-TO-RIGHT OVERRIDE character
==========

Powered by Google App Engine
This is Rietveld 408576698