Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

BUG=none
R=esprehn@chromium.org,haraken@chromium.org

Committed: https://crrev.com/e0d99834d5d8f817c55828c1f53b4d0946b2d6df
Cr-Commit-Position: refs/heads/master@{#385784}

[dcheng, 2016-04-07 00:26:11]

dcheng@chromium.org changed reviewers:
+ yutak@chromium.org

[dcheng, 2016-04-07 00:26:12]

https://codereview.chromium.org/1865913005/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
(right):

https://codereview.chromium.org/1865913005/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp:33:
OwnPtr<WebSyncRegistration> registration =
adoptPtr(webSyncRegistration.release());
FWIW, I think we'd be saving ourself trouble down the road if you could just
write std::move(webSyncRegistration) here.

[kinuko, 2016-04-07 00:36:46]

Yay~!! One DBC

https://codereview.chromium.org/1865913005/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebCallbacks.h (right):

https://codereview.chromium.org/1865913005/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebCallbacks.h:39: // When transferring
ownership, use |WebPrivatePassOwnPtr<X>| as a type
nit: WebPrivatePassOwnPtr<X> -> unique_ptr<X>

[dcheng, 2016-04-07 00:58:45]

https://codereview.chromium.org/1865913005/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebCallbacks.h (right):

https://codereview.chromium.org/1865913005/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebCallbacks.h:39: // When transferring
ownership, use |WebPrivatePassOwnPtr<X>| as a type
On 2016/04/07 at 00:36:45, kinuko wrote:
> nit: WebPrivatePassOwnPtr<X> -> unique_ptr<X>

Done, thanks.

[haraken, 2016-04-07 01:18:22]

LGTM

[vabr (Chromium), 2016-04-07 02:02:42]

components/password_manager/* LGTM
Thanks for this CL!
Vaclav

[Yuta Kitamura, 2016-04-07 04:13:58]

LGTM, thanks for doing this!

[dcheng, 2016-04-07 04:18:02]

dcheng@chromium.org changed reviewers:
+ mcilroy@chromium.org, mkwst@chromium.org, vabr@chromium.org

[dcheng, 2016-04-07 04:18:03]

+mcilroy for components/scheduler
+mkwst for components/test_runner
+esprehn for content

[esprehn, 2016-04-07 04:31:25]

lgtm

[Mike West, 2016-04-07 08:36:17]

LGTM!

[alex clarke (OOO till 29th), 2016-04-07 16:35:00]

alexclarke@chromium.org changed reviewers:
+ alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-04-07 16:35:01]

components/scheduler LGTM

[dcheng, 2016-04-07 16:35:58]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-07 16:35:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, vabr@chromium.org, yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/1865913005/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-07 16:36:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865913005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865913005/40001

[commit-bot: I haz the power, 2016-04-07 16:44:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-07 16:45:51]

Description was changed from

==========
Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

BUG=none
R=esprehn@chromium.org,haraken@chromium.org
==========

to

==========
Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

BUG=none
R=esprehn@chromium.org,haraken@chromium.org

Committed: https://crrev.com/e0d99834d5d8f817c55828c1f53b4d0946b2d6df
Cr-Commit-Position: refs/heads/master@{#385784}
==========

[commit-bot: I haz the power, 2016-04-07 16:45:54]

Patchset 3 (id:??) landed as
https://crrev.com/e0d99834d5d8f817c55828c1f53b4d0946b2d6df
Cr-Commit-Position: refs/heads/master@{#385784}