Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196533003: Oilpan: Prepare to move AbstractSQLTransaction and SQLTransaction to Oilpan heap. (Closed)

Created:
6 years, 9 months ago by tkent
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Oilpan: Prepare to move AbstractSQLTransaction and SQLTransaction to Oilpan heap. BUG=347902 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169308

Patch Set 1 : #

Total comments: 3

Patch Set 2 : pure virtual #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M Source/modules/webdatabase/AbstractSQLTransaction.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/modules/webdatabase/Database.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M Source/modules/webdatabase/DatabaseBackend.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseBackend.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransaction.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.cpp View 1 2 chunks +7 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackend.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackend.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tkent
6 years, 9 months ago (2014-03-12 06:06:09 UTC) #1
tkent
This is a straight-forward change. Can anyone stamp this?
6 years, 9 months ago (2014-03-14 00:37:04 UTC) #2
Mads Ager (chromium)
LGTM, sorry for the slow review, this slipped through my filters.
6 years, 9 months ago (2014-03-14 08:49:28 UTC) #3
haraken
LGTM2. This slipped through my filter as well... https://codereview.chromium.org/196533003/diff/10001/Source/modules/webdatabase/AbstractSQLTransaction.h File Source/modules/webdatabase/AbstractSQLTransaction.h (right): https://codereview.chromium.org/196533003/diff/10001/Source/modules/webdatabase/AbstractSQLTransaction.h#newcode40 Source/modules/webdatabase/AbstractSQLTransaction.h:40: virtual ...
6 years, 9 months ago (2014-03-14 08:53:01 UTC) #4
Erik Corry
lgtm https://codereview.chromium.org/196533003/diff/10001/Source/modules/webdatabase/AbstractSQLTransaction.h File Source/modules/webdatabase/AbstractSQLTransaction.h (right): https://codereview.chromium.org/196533003/diff/10001/Source/modules/webdatabase/AbstractSQLTransaction.h#newcode40 Source/modules/webdatabase/AbstractSQLTransaction.h:40: virtual void trace(Visitor*) { } On 2014/03/14 08:53:01, ...
6 years, 9 months ago (2014-03-14 09:07:11 UTC) #5
tkent
https://codereview.chromium.org/196533003/diff/10001/Source/modules/webdatabase/AbstractSQLTransaction.h File Source/modules/webdatabase/AbstractSQLTransaction.h (right): https://codereview.chromium.org/196533003/diff/10001/Source/modules/webdatabase/AbstractSQLTransaction.h#newcode40 Source/modules/webdatabase/AbstractSQLTransaction.h:40: virtual void trace(Visitor*) { } On 2014/03/14 09:07:11, Erik ...
6 years, 9 months ago (2014-03-15 17:00:28 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-15 17:00:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/196533003/30001
6 years, 9 months ago (2014-03-15 18:54:39 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-15 19:41:37 UTC) #9
Message was sent while issue was closed. 
Change committed as 169308

Powered by Google App Engine
This is Rietveld 408576698