[iOS] Add a template to repack and define bundle resources to grit.

[iOS] Add a template to repack and define bundle resources to grit.

On iOS, packed resources needs to be copied into the application bundle
which is done using bundle_data targets. Define a new template to easily
invoke repack and additionally define the bundle_data target for use on
iOS.

BUG=459705
Committed: https://crrev.com/1d665e802edd3c4759c72bd7a746879fe3d08c86
Cr-Commit-Position: refs/heads/master@{#395962}

[sdefresne, 2016-05-25 08:27:45]

sdefresne@chromium.org changed reviewers:
+ thakis@chromium.org

[sdefresne, 2016-05-25 08:27:46]

Please take a look.

[sdefresne, 2016-05-25 08:32:47]

Patchset #1 (id:1) has been deleted

[sdefresne, 2016-05-25 08:35:59]

Patchset #1 (id:20001) has been deleted

[sdefresne, 2016-05-25 11:45:58]

Patchset #1 (id:40001) has been deleted

[Nico, 2016-05-25 13:28:16]

thakis@chromium.org changed reviewers:
+ rsesek@chromium.org

[Nico, 2016-05-25 13:28:16]

lgtm if rsesek thinks it's ok

[Robert Sesek, 2016-05-25 14:58:51]

lgtm

https://codereview.chromium.org/2009803002/diff/60001/tools/grit/repack.gni
File tools/grit/repack.gni (right):

https://codereview.chromium.org/2009803002/diff/60001/tools/grit/repack.gni#n...
tools/grit/repack.gni:56: # to move them to the application bundle. This is
mostly useful on iOS and Mac.
On Mac this isn't necessary. I've already done the repack bundle stuff, and
unfortunately it's rather complicated compared to this template.

https://codereview.chromium.org/2009803002/diff/60001/tools/grit/repack.gni#n...
tools/grit/repack.gni:89: forward_variables_from(invoker, [ "visibility" ])
Might need testonly at some point, and online 80

[sdefresne, 2016-05-25 15:09:43]

On 2016/05/25 at 14:58:51, rsesek wrote:
> lgtm
> 
> https://codereview.chromium.org/2009803002/diff/60001/tools/grit/repack.gni
> File tools/grit/repack.gni (right):
> 
>
https://codereview.chromium.org/2009803002/diff/60001/tools/grit/repack.gni#n...
> tools/grit/repack.gni:56: # to move them to the application bundle. This is
mostly useful on iOS and Mac.
> On Mac this isn't necessary. I've already done the repack bundle stuff, and
unfortunately it's rather complicated compared to this template.

Thank, will fix the comment and description to just mention iOS.

>
https://codereview.chromium.org/2009803002/diff/60001/tools/grit/repack.gni#n...
> tools/grit/repack.gni:89: forward_variables_from(invoker, [ "visibility" ])
> Might need testonly at some point, and online 80

I was wondering about testonly. I don't think it would be necessary as
"testonly" target can depends on non-"testonly" one, and I don't see the need to
repacking data just for tests. If the need arise, I'll prefer to do it in a
followup CL.

[sdefresne, 2016-05-25 15:13:34]

Description was changed from

==========
[iOS/Mac] Add a template to repack and define bundle resources to grit.

On iOS and Mac, packed resources needs to be copied into the application
bundle which is done using bundle_data targets. Define a new template to
easily invoke repack and additionally define the bundle_data target for
use on iOS and Mac.

BUG=459705
==========

to

==========
[iOS] Add a template to repack and define bundle resources to grit.

On iOS, packed resources needs to be copied into the application bundle
which is done using bundle_data targets. Define a new template to easily
invoke repack and additionally define the bundle_data target for use on
iOS.

BUG=459705
==========

[Robert Sesek, 2016-05-25 16:19:22]

lgtm

[sdefresne, 2016-05-25 17:25:08]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-05-25 17:25:08]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2009803002/#ps80001
(title: "Update description and comment to remove "Mac"")

[commit-bot: I haz the power, 2016-05-25 17:26:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009803002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009803002/80001

[commit-bot: I haz the power, 2016-05-25 19:36:33]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-05-25 19:38:38]

Description was changed from

==========
[iOS] Add a template to repack and define bundle resources to grit.

On iOS, packed resources needs to be copied into the application bundle
which is done using bundle_data targets. Define a new template to easily
invoke repack and additionally define the bundle_data target for use on
iOS.

BUG=459705
==========

to

==========
[iOS] Add a template to repack and define bundle resources to grit.

On iOS, packed resources needs to be copied into the application bundle
which is done using bundle_data targets. Define a new template to easily
invoke repack and additionally define the bundle_data target for use on
iOS.

BUG=459705

Committed: https://crrev.com/1d665e802edd3c4759c72bd7a746879fe3d08c86
Cr-Commit-Position: refs/heads/master@{#395962}
==========

[commit-bot: I haz the power, 2016-05-25 19:38:39]

Patchset 2 (id:??) landed as
https://crrev.com/1d665e802edd3c4759c72bd7a746879fe3d08c86
Cr-Commit-Position: refs/heads/master@{#395962}