Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2010333003: Convert undo-indent*.html to use w3c test harness (Closed)

Created:
4 years, 7 months ago by yosin_UTC9
Modified:
4 years, 6 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert undo-indent*.html to use w3c test harness This patch changes "undo-indent.html" to use w3c test harness with |assert_selection()| and merges "undo-indent-noneditable.html" into it since both tests are similar pattern to simplify for source code for improving code health. This patch is a preparation of committing crrev.com/2001083002, Make FrameSelection to track associated Document. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/70ce425bdf42254d4fb40ea7e8e3a26dc620872e Cr-Commit-Position: refs/heads/master@{#396678}

Patch Set 1 : 2016-05-27T11:26:03 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -128 lines) Patch
M third_party/WebKit/LayoutTests/editing/undo/undo-indent.html View 1 chunk +25 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/undo/undo-indent-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/undo/undo-indent-noneditable.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/undo/undo-indent-noneditable-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
yosin_UTC9
PTAL
4 years, 7 months ago (2016-05-27 04:20:16 UTC) #3
yoichio
lgtm
4 years, 6 months ago (2016-05-30 02:21:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010333003/1
4 years, 6 months ago (2016-05-30 04:21:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 05:24:01 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 05:25:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70ce425bdf42254d4fb40ea7e8e3a26dc620872e
Cr-Commit-Position: refs/heads/master@{#396678}

Powered by Google App Engine
This is Rietveld 408576698