Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2019693002: MIPS: Fix '[turbofan] Introduce new operators Float32SubPreserveNan and Float64SubPreserveNan'. (Closed)

Created:
4 years, 6 months ago by Marija Antic
Modified:
4 years, 6 months ago
Reviewers:
ivica.bogosavljevic, ilija.pavlovic, balazs.kilvady, miran.karic, titzer, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix '[turbofan] Introduce new operators Float32SubPreserveNan and Float64SubPreserveNan'. Port 481502dad9b45a38c86387d50cebe52f00b072ad Float32SubMinusZero and Float64SubMinusZero tests are failing because MIPS does not preserve NaN payload according to Wasm spec. Implemented macro-assembler methods that check for NaN operands, and return the qNaN value with preserved payload and sign bits. TEST=Run_WasmFloat32SubMinusZero, Run_WasmFloat64SubMinusZero BUG=

Patch Set 1 #

Patch Set 2 : Rebase and fix a typo #

Patch Set 3 : Addressing comments and fixing interpreted wasm tests #

Patch Set 4 : Use heap NaN instead of FCSR to determine NaN encoding. #

Patch Set 5 : Check operands for NaN only if neccessary. #

Patch Set 6 : Revert Patch Set 5. #

Patch Set 7 : Check operands for NaN only if necessary. #

Patch Set 8 : Fix instruction selector mips64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -9 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 3 4 5 6 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 3 4 5 6 7 2 chunks +8 lines, -2 lines 0 comments Download
M src/mips/constants-mips.h View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 3 4 6 1 chunk +91 lines, -0 lines 0 comments Download
M src/mips64/constants-mips64.h View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 3 4 5 6 1 chunk +85 lines, -0 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 1 2 3 4 5 6 5 chunks +20 lines, -2 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 3 4 6 1 chunk +34 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
Marija Antic
PTAL.
4 years, 6 months ago (2016-05-27 13:13:54 UTC) #3
Marija Antic
4 years, 6 months ago (2016-06-08 11:48:44 UTC) #9
balazs.kilvady
lgtm, The message should be: MIPS: Fix '[turbofan] Introduce new operators Float32SubPreserveNan and Float64SubPreserveNan for ...
4 years, 6 months ago (2016-06-09 09:57:10 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019693002/60001
4 years, 6 months ago (2016-06-09 09:58:48 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 10:23:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019693002/60001
4 years, 6 months ago (2016-06-09 10:37:24 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16837)
4 years, 6 months ago (2016-06-09 10:41:55 UTC) #19
balazs.kilvady
We need an lgtm from a v8-team member for changes in wasm interpreter, PTAL.
4 years, 6 months ago (2016-06-09 12:26:47 UTC) #21
Marija Antic
Check for NaN operand is performed only if the result of subtraction is a NaN ...
4 years, 6 months ago (2016-06-10 12:38:07 UTC) #25
balazs.kilvady
4 years, 6 months ago (2016-06-15 08:42:40 UTC) #26
NOT LGTM

Powered by Google App Engine
This is Rietveld 408576698