Issue 2131823002: [parser] report errors for invalid binding patterns in async formal parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2131823002: [parser] report errors for invalid binding patterns in async formal parameters (Closed)

Created:
4 years, 5 months ago by caitp (gmail)

Modified:
4 years, 5 months ago

Reviewers:
nickie, caitp, Dan Ehrenberg

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[parser] report errors for invalid binding patterns in async formal parameters BUG=v8:4483, v8:5190 R=littledan@chromium.org, nikolaos@chromium.org

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -17 lines)			Patch
M	src/parsing/expression-classifier.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/parsing/parser-base.h	View	8 chunks	+43 lines, -17 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

caitp

On 2016/07/08 03:24:14, caitp wrote: > PTAL not ready yet, causes some issues in object-values/entries ...

4 years, 5 months ago (2016-07-08 16:41:09 UTC) #3

caitp

4 years, 5 months ago (2016-07-08 17:34:16 UTC) #4

On 2016/07/08 16:41:09, caitp wrote:
> On 2016/07/08 03:24:14, caitp wrote:
> > PTAL
> 
> not ready yet, causes some issues in object-values/entries tests

sorry, accidentally sent that message to the wrong CL. and the patch to the
wrong CL too. derp.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages