[Sync] //components/sync manual changes [DO NOT SUBMIT]

[Sync] //components/sync manual changes [DO NOT SUBMIT]

There are a bunch of subfolder reorganizations going along with this:

- engine/ -> engine_impl/
- sessions/ -> sessions_impl/
- util/ -> base/
- internal_api/public/base/ -> base/
- internal_api/public/sessions/ -> sessions/
- internal_api/public/engine/ -> engine/
- internal_api/public/events/ -> engine/events/
- internal_api/public/util/ -> base/
- internal_api/public/ -> core/
- internal_api/ -> core_impl/

The base change was generated using the following script:
http://pastebin.com/vVAkRCkh

This issue only contains the manual changes based on top of those automated
ones so they can be reviewed more easily.

This is a minimal change to support file movement; it doesn't do
anything like merging sync_unit_tests into component_unit tests.

BUG=626114

[maxbogue, 2016-07-15 19:22:23]

maxbogue@chromium.org changed reviewers:
+ zea@chromium.org

[maxbogue, 2016-07-15 19:22:24]

Hey Nicolas, here are the manual changes for review.

[Nicolas Zea, 2016-07-19 18:21:06]

https://codereview.chromium.org/2155763002/diff/20001/components/sync/core/DEPS
File components/sync/core/DEPS (right):

https://codereview.chromium.org/2155763002/diff/20001/components/sync/core/DE...
components/sync/core/DEPS:6: "+components/sync/engine_impl",
it seems odd to allow depending on impl folders from outside of the folder. I.e.
shouldn't only engine be allowed to use engine_impl?

https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine/...
File components/sync/engine/DEPS (right):

https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine/...
components/sync/engine/DEPS:3: # TODO(maxbogue): Move to engine.
Why move this? This is an interface to access the engine, and isn't that what
core is for?

https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine_...
File components/sync/engine_impl/DEPS (right):

https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine_...
components/sync/engine_impl/DEPS:3: # TODO(maxbogue): Move to engine.
Same comment about moving this. Maybe I'm not clear on core vs engine?

[maxbogue, 2016-07-19 18:58:19]

https://codereview.chromium.org/2155763002/diff/20001/components/sync/core/DEPS
File components/sync/core/DEPS (right):

https://codereview.chromium.org/2155763002/diff/20001/components/sync/core/DE...
components/sync/core/DEPS:6: "+components/sync/engine_impl",
On 2016/07/19 18:21:06, Nicolas Zea wrote:
> it seems odd to allow depending on impl folders from outside of the folder.
I.e.
> shouldn't only engine be allowed to use engine_impl?

Right now the _impl folders really mean "don't use outside of the sync
component". If we layer stuff well enough it may make sense to tighten it as you
say later on.

https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine/...
File components/sync/engine/DEPS (right):

https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine/...
components/sync/engine/DEPS:3: # TODO(maxbogue): Move to engine.
On 2016/07/19 18:21:06, Nicolas Zea wrote:
> Why move this? This is an interface to access the engine, and isn't that what
> core is for?

As I mentioned offline, I think in the end it will make sense to remove
core(_impl) entirely and split it into engine/ and driver/ (since those will be
able to have _impl folders of their own).

https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine_...
File components/sync/engine_impl/DEPS (right):

https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine_...
components/sync/engine_impl/DEPS:3: # TODO(maxbogue): Move to engine.
On 2016/07/19 18:21:06, Nicolas Zea wrote:
> Same comment about moving this. Maybe I'm not clear on core vs engine?

Yeah, core vs engine is no longer a super meaningful distinction. Future work!

[Nicolas Zea, 2016-07-19 19:29:54]

On 2016/07/19 18:58:19, maxbogue wrote:
>
https://codereview.chromium.org/2155763002/diff/20001/components/sync/core/DEPS
> File components/sync/core/DEPS (right):
> 
>
https://codereview.chromium.org/2155763002/diff/20001/components/sync/core/DE...
> components/sync/core/DEPS:6: "+components/sync/engine_impl",
> On 2016/07/19 18:21:06, Nicolas Zea wrote:
> > it seems odd to allow depending on impl folders from outside of the folder.
> I.e.
> > shouldn't only engine be allowed to use engine_impl?
> 
> Right now the _impl folders really mean "don't use outside of the sync
> component". If we layer stuff well enough it may make sense to tighten it as
you
> say later on.
> 
>
https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine/...
> File components/sync/engine/DEPS (right):
> 
>
https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine/...
> components/sync/engine/DEPS:3: # TODO(maxbogue): Move to engine.
> On 2016/07/19 18:21:06, Nicolas Zea wrote:
> > Why move this? This is an interface to access the engine, and isn't that
what
> > core is for?
> 
> As I mentioned offline, I think in the end it will make sense to remove
> core(_impl) entirely and split it into engine/ and driver/ (since those will
be
> able to have _impl folders of their own).
> 
>
https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine_...
> File components/sync/engine_impl/DEPS (right):
> 
>
https://codereview.chromium.org/2155763002/diff/20001/components/sync/engine_...
> components/sync/engine_impl/DEPS:3: # TODO(maxbogue): Move to engine.
> On 2016/07/19 18:21:06, Nicolas Zea wrote:
> > Same comment about moving this. Maybe I'm not clear on core vs engine?
> 
> Yeah, core vs engine is no longer a super meaningful distinction. Future work!

Worth removing those comments then? It seems like they just add to the
confusion, maybe just mention the plan to merge core and engine eventually?

[maxbogue, 2016-07-19 19:52:18]

On 2016/07/19 19:29:54, Nicolas Zea wrote:
> Worth removing those comments then? It seems like they just add to the
> confusion, maybe just mention the plan to merge core and engine eventually?

The comments are notes for me on weird dependencies that I want to correct
quickly after this lands. It will take longer to remove core entirely.

[Nicolas Zea, 2016-07-25 18:32:27]

LGTM

[maxbogue, 2016-07-25 21:47:17]

maxbogue@chromium.org changed reviewers:
+ jam@chromium.org

[maxbogue, 2016-07-25 21:47:18]

+jam FYI these are the manual changes that the script cherry-picks in.

[jam, 2016-07-25 22:13:36]

lgtm