[Sync] //components/sync internal changes [DO NOT SUBMIT]

[Sync] //components/sync internal changes [DO NOT SUBMIT]

There are a bunch of subfolder reorganizations going along with this:

- engine/ -> engine_impl/
- sessions/ -> sessions_impl/
- util/ -> base/
- internal_api/public/base/ -> base/
- internal_api/public/sessions/ -> sessions/
- internal_api/public/engine/ -> engine/
- internal_api/public/events/ -> engine/events/
- internal_api/public/util/ -> base/
- internal_api/public/ -> core/
- internal_api/ -> core_impl/

The full change was generated using the following script:
http://pastebin.com/vVAkRCkh

This CL contains only the portion of the changes within //components/sync.

BUG=626114

[maxbogue, 2016-07-15 19:47:29]

maxbogue@chromium.org changed reviewers:
+ zea@chromium.org

[maxbogue, 2016-07-15 19:47:34]

Here are all the changes within the //components/sync folder.

[Nicolas Zea, 2016-07-18 19:57:31]

LGTM

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/jav...
File
components/sync/android/java/src/org/chromium/components/sync/notifier/InvalidationPreferences.java
(right):

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/jav...
components/sync/android/java/src/org/chromium/components/sync/notifier/InvalidationPreferences.java:80:
private static final String TAG = "InvalidationPrefs";
Why did this change?

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/mod...
File components/sync/android/model_type_helper.h (left):

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/mod...
components/sync/android/model_type_helper.h:13: 
keep the newline, and a // namespace syncer comment (maybe that's why the
formatter made the change?)

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/syn...
File components/sync/android/sync_jni_registrar.h (left):

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/syn...
components/sync/android/sync_jni_registrar.h:16: }
here too

[maxbogue, 2016-07-18 21:26:51]

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/jav...
File
components/sync/android/java/src/org/chromium/components/sync/notifier/InvalidationPreferences.java
(right):

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/jav...
components/sync/android/java/src/org/chromium/components/sync/notifier/InvalidationPreferences.java:80:
private static final String TAG = "InvalidationPrefs";
On 2016/07/18 19:57:31, Nicolas Zea wrote:
> Why did this change?

The TAG is limited to 20 characters. It failed a presubmit without this change.
I guess it didn't pop up in http://crrev.com/2134363002 because the line wasn't
changed.

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/mod...
File components/sync/android/model_type_helper.h (left):

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/mod...
components/sync/android/model_type_helper.h:13: 
On 2016/07/18 19:57:31, Nicolas Zea wrote:
> keep the newline, and a // namespace syncer comment (maybe that's why the
> formatter made the change?)

Yeah, looks like that was why. Done in the manual change.

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/syn...
File components/sync/android/sync_jni_registrar.h (left):

https://codereview.chromium.org/2156693002/diff/1/components/sync/android/syn...
components/sync/android/sync_jni_registrar.h:16: }
On 2016/07/18 19:57:31, Nicolas Zea wrote:
> here too

Done.

[maxbogue, 2016-07-19 17:37:54]

maxbogue@chromium.org changed reviewers:
+ blundell@chromium.org

[maxbogue, 2016-07-19 17:37:56]

+Colin, PTAL at build stuff in this CL!

[maxbogue, 2016-07-25 22:04:46]

-blundell +jam; here are the internal changes. The build files are probably the
only interesting things here to someone outside the sync team.