Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2173783002: Adds visual viewport size override to DevTools Emulation protocol. (Closed)

Created:
4 years, 5 months ago by Eric Seckler
Modified:
4 years, 3 months ago
Reviewers:
dgozman, dcheng, pfeldman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, blink-reviews-api_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org, bokan, Sami, alexclarke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Obsolete.) Adds visual viewport size override to DevTools Emulation protocol. This enables resizing of the visual viewport for (headless) screenshots. For more information, see crbug.com/625577 and the design doc: bit.ly/viewport-screenshots. We will add additional overrides for scroll/scale of viewports in crrev.com/2096633002. BUG=625577

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment. #

Messages

Total messages: 12 (8 generated)
Eric Seckler
Split off from crrev.com/2096633002.
4 years, 5 months ago (2016-07-22 14:42:40 UTC) #7
dgozman
lgtm. Thanks for splitting this off. https://codereview.chromium.org/2173783002/diff/1/third_party/WebKit/public/web/WebDeviceEmulationParams.h File third_party/WebKit/public/web/WebDeviceEmulationParams.h (right): https://codereview.chromium.org/2173783002/diff/1/third_party/WebKit/public/web/WebDeviceEmulationParams.h#newcode56 third_party/WebKit/public/web/WebDeviceEmulationParams.h:56: // Emulated visual ...
4 years, 4 months ago (2016-07-25 22:13:54 UTC) #8
Eric Seckler
+dcheng for ipc change (view_messages.h). +pfeldman for content/ and WebKit/public/. Thanks! https://codereview.chromium.org/2173783002/diff/1/third_party/WebKit/public/web/WebDeviceEmulationParams.h File third_party/WebKit/public/web/WebDeviceEmulationParams.h (right): ...
4 years, 4 months ago (2016-07-26 08:33:50 UTC) #10
dcheng
4 years, 4 months ago (2016-07-26 11:05:02 UTC) #11
LGTM

Powered by Google App Engine
This is Rietveld 408576698