Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2269593003: SkPDF: paths as rects when possible (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 1 month ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: paths as rects when possible GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269593003

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2016-08-22 (Monday) 15:43:33 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/pdf/SkPDFUtils.cpp View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
hal.canary
PTAL
4 years, 4 months ago (2016-08-22 19:01:10 UTC) #5
bungeman-skia
4 years, 4 months ago (2016-08-22 19:28:18 UTC) #6 
https://codereview.chromium.org/2269593003/diff/1/src/pdf/SkPDFUtils.cpp
File src/pdf/SkPDFUtils.cpp (right):

https://codereview.chromium.org/2269593003/diff/1/src/pdf/SkPDFUtils.cpp#newc...
src/pdf/SkPDFUtils.cpp:130: if (isClosed && SkPath::kCW_Direction == direction)
{
Is the check for CW really needed? What's the output if CCW? Mostly just
curious.

https://codereview.chromium.org/2269593003/diff/1/src/pdf/SkPDFUtils.cpp#newc...
src/pdf/SkPDFUtils.cpp:131: //SkPDFUtils::AppendRectangle(rect, content);
Either this should be written and used or the comment removed.

Powered by Google App Engine
This is Rietveld 408576698